From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10810 invoked by alias); 17 Jun 2011 15:34:40 -0000 Received: (qmail 10653 invoked by uid 22791); 17 Jun 2011 15:34:39 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Jun 2011 15:34:24 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5HFYLVf013991 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Jun 2011 11:34:22 -0400 Received: from anchor.twiddle.net (vpn-237-232.phx2.redhat.com [10.3.237.232]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p5HFYKrh013441; Fri, 17 Jun 2011 11:34:20 -0400 Message-ID: <4DFB73FC.2030400@redhat.com> Date: Fri, 17 Jun 2011 17:26:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 MIME-Version: 1.0 To: Georg-Johann Lay CC: gcc-patches@gcc.gnu.org, Denis Chertykov , "Eric B. Weddington" , Anatoly Sokolov Subject: Re: [Patch, AVR]: PR49313, fix PR29524 References: <4DF87FAD.4090104@gjlay.de> <4DFA55B2.4010406@redhat.com> <4DFB1C6F.1050807@gjlay.de> In-Reply-To: <4DFB1C6F.1050807@gjlay.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01345.txt.bz2 On 06/17/2011 02:20 AM, Georg-Johann Lay wrote: > Richard Henderson schrieb: >> On 06/15/2011 02:47 AM, Georg-Johann Lay wrote: >>> +#if defined (L_loop_ffsqi2) >>> +;; Helper for ffshi2, ffssi2 >>> +;; r25:r24 = r26 + zero_extend16 (ffs8(r24)) >>> +;; r24 must be != 0 >>> +;; clobbers: r26 >>> +DEFUN __loop_ffsqi2 >> >> Why does this function have "loop" in its name? The actual >> implementation is surely irrelevant. > > hmmm. I needed some global name that can be referenced from __ffshi2 > resp. __ffssi2. The function in itself is not very helpful as stand > alone. You prefer some other naming for such global helpers? __ffsqi_nz perhaps? > The following instruction is BRNE, a conditional branch. Oops, missed that, sorry. > Yes, you are right. Following patchlet ok? > > Johann > > > * config/avr/libgcc.S (__ctzsi2, __ctzhi2): > Map zero to 255. You'd also delete the COUNT_LEADING_ZEROS_0 definition in longlong.h. r~