From: Andrew Haley <aph@redhat.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [libjava] Fix md5test, shatest on Tru64 UNIX with native libiconv (PR libgcj/49314)
Date: Tue, 21 Jun 2011 17:24:00 -0000 [thread overview]
Message-ID: <4E00CC33.40107@redhat.com> (raw)
In-Reply-To: <yddpqm7i90w.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On 06/21/2011 02:55 PM, Rainer Orth wrote:
> As described in the PR, unless the UTF-8 encoding of \ufeff is padded
> with a NUL byte, the iconv_init test fails for the native Tru64 UNIX
> libiconv, iconv_byte_swap isn't set correctly and later iconv calls
> fail. This patch fixes this, allowing the arraycopy testcase in the PR
> and the actual md5test and shatest testcases to succeed. This way, I
> get clean libjava testsuite results.
>
> Tested by rebuilding libgcj.so with the fixed natIconv.cc. A full
> rebuild and test of libgcj is currently running on alpha-dec-osf5.1b.
>
> Ok for mainline if it passes?
>
> Thanks.
> Rainer
>
>
> 2011-06-21 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> PR libgcj/49314
> * gnu/gcj/convert/natIconv.cc (iconv_init): Pad in[] with NUL byte.
>
Sure, thanks.
Andrew.
prev parent reply other threads:[~2011-06-21 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 14:28 Rainer Orth
2011-06-21 17:24 ` Andrew Haley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E00CC33.40107@redhat.com \
--to=aph@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).