From: Nathan Sidwell <nathan@codesourcery.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org>
Cc: gcc-patches@gcc.gnu.org,
"Joseph S. Myers" <joseph@codesourcery.com>,
Richard Earnshaw <rearnsha@arm.com>
Subject: Re: [ARM] TLS Descriptor support
Date: Wed, 22 Jun 2011 17:52:00 -0000 [thread overview]
Message-ID: <4E022052.7020901@codesourcery.com> (raw)
In-Reply-To: <BANLkTinYWi-uNM7FPwLPdZpxgNUcZBuHsw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On 06/21/11 18:24, Ramana Radhakrishnan wrote:
>> revalidated with defaults to both gnu and gnu2 style. ok?
>
> This is OK .
sigh, in backporting the relevant bits, I noticed a problem with the
OPTION_DEFAULT_SPECS string, fixed thusly, committed as obvious. And then I
noticed I'd failed to commit the config.gcc fragment.
Back of the class for me today :(
nathan
--
Nathan Sidwell
[-- Attachment #2: all.diff --]
[-- Type: text/plain, Size: 2102 bytes --]
2011-06-22 Nathan Sidwell <nathan@codesourcery.com>
* config/arm/arm.h (OPTION_DEFAULT_SPECS): Fix -mtls-dialect
typo.
* config.gcc (arm*-*-linux*): Default to gnu tls.
(arm*-*-*): Add --with-tls option.
(all_defaults): Add 'tls'.
Index: config.gcc
===================================================================
--- config.gcc (revision 175297)
+++ config.gcc (working copy)
@@ -863,6 +863,7 @@
tmake_file="$tmake_file arm/t-linux"
;;
esac
+ with_tls=${with_tls:-gnu}
tm_file="$tm_file arm/aout.h arm/arm.h"
tmake_file="${tmake_file} arm/t-arm-softfp soft-fp/t-softfp"
;;
@@ -3039,7 +3040,7 @@
;;
arm*-*-*)
- supported_defaults="arch cpu float tune fpu abi mode"
+ supported_defaults="arch cpu float tune fpu abi mode tls"
for which in cpu tune; do
# See if it matches any of the entries in arm-cores.def
eval "val=\$with_$which"
@@ -3122,6 +3123,17 @@
;;
esac
+ case "$with_tls" in
+ "" \
+ | gnu | gnu2)
+ # OK
+ ;;
+ *)
+ echo "Unknown TLS method used in --with-tls=$with_tls" 1>&2
+ exit 1
+ ;;
+ esac
+
if test "x$with_arch" != x && test "x$with_cpu" != x; then
echo "Warning: --with-arch overrides --with-cpu=$with_cpu" 1>&2
fi
@@ -3601,7 +3613,7 @@
esac
t=
-all_defaults="abi cpu cpu_32 cpu_64 arch arch_32 arch_64 tune tune_32 tune_64 schedule float mode fpu divide llsc mips-plt synci"
+all_defaults="abi cpu cpu_32 cpu_64 arch arch_32 arch_64 tune tune_32 tune_64 schedule float mode fpu divide llsc mips-plt synci tls"
for option in $all_defaults
do
eval "val=\$with_"`echo $option | sed s/-/_/g`
Index: config/arm/arm.h
===================================================================
--- config/arm/arm.h (revision 175297)
+++ config/arm/arm.h (working copy)
@@ -324,7 +324,7 @@
{"fpu", "%{!mfpu=*:-mfpu=%(VALUE)}"}, \
{"abi", "%{!mabi=*:-mabi=%(VALUE)}"}, \
{"mode", "%{!marm:%{!mthumb:-m%(VALUE)}}"}, \
- {"tls", "%{!mtls-dialect:-mtls-dialect=%(VALUE)}"},
+ {"tls", "%{!mtls-dialect=*:-mtls-dialect=%(VALUE)}"},
/* Which floating point model to use. */
enum arm_fp_model
prev parent reply other threads:[~2011-06-22 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 11:23 Nathan Sidwell
2011-05-10 13:14 ` Joseph S. Myers
2011-05-11 15:43 ` Nathan Sidwell
2011-05-26 9:32 ` Nathan Sidwell
2011-05-27 4:43 ` Ramana Radhakrishnan
2011-05-31 13:03 ` Nathan Sidwell
2011-06-03 22:50 ` Ramana Radhakrishnan
2011-06-06 9:50 ` Nathan Sidwell
2011-06-06 9:54 ` Ramana Radhakrishnan
2011-06-06 9:56 ` Nathan Sidwell
2011-06-06 16:10 ` Ramana Radhakrishnan
2011-06-06 16:27 ` Richard Earnshaw
2011-06-07 6:11 ` Nathan Sidwell
2011-06-07 13:08 ` Richard Earnshaw
2011-06-21 8:42 ` Nathan Sidwell
2011-06-21 18:03 ` Ramana Radhakrishnan
2011-06-22 17:52 ` Nathan Sidwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E022052.7020901@codesourcery.com \
--to=nathan@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=ramana.radhakrishnan@linaro.org \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).