From: Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org>
To: Janis Johnson <janisjo@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [testsuite] ARM test pr42093.c: thumb2 or thumb1
Date: Fri, 24 Jun 2011 13:38:00 -0000 [thread overview]
Message-ID: <4E048EB5.3040207@linaro.org> (raw)
In-Reply-To: <4E03DD02.6010706@codesourcery.com>
On 24/06/11 01:40, Janis Johnson wrote:
> Test gcc.target/arm/pr42093.c, added by Ramana, requires support for
> arm_thumb2 but fails for those targets. The patch for which it was
> added modified support for thumb1. Should the test instead require
> arm_thumb1_ok, as in this patch?
No this is for a Thumb2 defect so the test is valid for Thumb2 - we
shouldn't be generating a tbb / tbh with signed offsets and that's what
was happening there.
This test I think ends up being fragile because the generation of tbb /
tbh depends on how the blocks have been laid out . It would be
interesting to try and get a test that works reliably in T2 .
cheers
Ramana
>
> Janis
next prev parent reply other threads:[~2011-06-24 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 1:02 Janis Johnson
2011-06-24 13:38 ` Ramana Radhakrishnan [this message]
2011-07-01 9:03 ` Richard Earnshaw
2011-07-01 19:57 ` Janis Johnson
2011-07-04 9:27 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E048EB5.3040207@linaro.org \
--to=ramana.radhakrishnan@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=janisjo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).