From: Matthias Klose <doko@ubuntu.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Subject: Re: [patch, 4.6/4.7] fix installation of plugin header files
Date: Fri, 24 Jun 2011 21:05:00 -0000 [thread overview]
Message-ID: <4E04EA1F.9000203@ubuntu.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1106201514280.16125@digraph.polyomino.org.uk>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On 06/20/2011 05:18 PM, Joseph S. Myers wrote:
> On Mon, 20 Jun 2011, Matthias Klose wrote:
>
>> - PR45078; vxworks-dummy.h is included for cpu_type in arm,
>> i386, mips, sh and sparc but only installed when it's i386; copy it
>> manually anytime.
>
> I don't think you should list particular config/ headers in PLUGIN_HEADERS
> in Makefile.in; provide a way for targets to specify their additions to
> this list in config.gcc instead. Is the issue headers that are directly
> #included from tm.h headers (for whatever reason) rather than listed in
> tm_file? (Some of those #includes may be avoidable, but the .def ones
> probably do need listing explicitly.)
>
> The aim should be to get the extra files in tm_file_list, which is
> included in PLUGIN_HEADERS, so that they appear in $(TM_H) dependencies as
> well.
updated patch attached.
Matthias
[-- Attachment #2: p.diff --]
[-- Type: text/x-diff, Size: 1234 bytes --]
2011-06-24 Matthias Klose <doko@ubuntu.com>
PR plugin/45078
* Makefile.in (PLUGIN_HEADERS): Add config/arm/arm-cores.def.
(install-plugin): Install c-family headers into a c-family subdir.
* config.gcc: Add vxworks-dummy.h to tm_file for arm, mips, sh and
sparc targets.
--- gcc/Makefile.in
+++ gcc/Makefile.in
@@ -4503,6 +4503,7 @@
$(EXCEPT_H) tree-ssa-sccvn.h real.h output.h $(IPA_UTILS_H) \
$(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
+ config/arm/arm-cores.def \
$(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
# generate the 'build fragment' b-header-vars
@@ -4527,7 +4528,7 @@
else continue; \
fi; \
case $$path in \
- "$(srcdir)"/config/* | "$(srcdir)"/*.def ) \
+ "$(srcdir)"/config/* | "$(srcdir)"/c-family/* | "$(srcdir)"/*.def ) \
base=`echo "$$path" | sed -e "s|$$srcdirstrip/||"`;; \
*) base=`basename $$path` ;; \
esac; \
--- gcc/config.gcc
+++ gcc/config.gcc
@@ -467,6 +467,9 @@
fi
tm_file="vxworks-dummy.h ${tm_file}"
;;
+arm*-*-*|mips*-*-*|sh*-*-*|sparc*-*-*)
+ tm_file="vxworks-dummy.h ${tm_file}"
+ ;;
esac
# On a.out targets, we need to use collect2.
next prev parent reply other threads:[~2011-06-24 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 13:46 Matthias Klose
2011-06-20 15:22 ` Joseph S. Myers
2011-06-24 21:05 ` Matthias Klose [this message]
2011-06-24 21:08 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E04EA1F.9000203@ubuntu.com \
--to=doko@ubuntu.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=ramana.radhakrishnan@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).