From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17669 invoked by alias); 24 Jun 2011 19:49:25 -0000 Received: (qmail 17640 invoked by uid 22791); 24 Jun 2011 19:49:23 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from adelie.canonical.com (HELO adelie.canonical.com) (91.189.90.139) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 24 Jun 2011 19:49:00 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by adelie.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1QaCN5-0002Cy-PZ; Fri, 24 Jun 2011 19:48:57 +0000 Received: from dslb-088-073-084-106.pools.arcor-ip.net ([88.73.84.106] helo=[192.168.42.17]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QaCN5-0005RH-Lr; Fri, 24 Jun 2011 19:48:55 +0000 Message-ID: <4E04EA1F.9000203@ubuntu.com> Date: Fri, 24 Jun 2011 21:05:00 -0000 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110516 Thunderbird/3.1.10 MIME-Version: 1.0 To: "Joseph S. Myers" CC: GCC Patches , Ramana Radhakrishnan Subject: Re: [patch, 4.6/4.7] fix installation of plugin header files References: <4DFF4EB6.5010902@ubuntu.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------030508060506090409080805" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01896.txt.bz2 This is a multi-part message in MIME format. --------------030508060506090409080805 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 875 On 06/20/2011 05:18 PM, Joseph S. Myers wrote: > On Mon, 20 Jun 2011, Matthias Klose wrote: > >> - PR45078; vxworks-dummy.h is included for cpu_type in arm, >> i386, mips, sh and sparc but only installed when it's i386; copy it >> manually anytime. > > I don't think you should list particular config/ headers in PLUGIN_HEADERS > in Makefile.in; provide a way for targets to specify their additions to > this list in config.gcc instead. Is the issue headers that are directly > #included from tm.h headers (for whatever reason) rather than listed in > tm_file? (Some of those #includes may be avoidable, but the .def ones > probably do need listing explicitly.) > > The aim should be to get the extra files in tm_file_list, which is > included in PLUGIN_HEADERS, so that they appear in $(TM_H) dependencies as > well. updated patch attached. Matthias --------------030508060506090409080805 Content-Type: text/x-diff; name="p.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="p.diff" Content-length: 1234 2011-06-24 Matthias Klose PR plugin/45078 * Makefile.in (PLUGIN_HEADERS): Add config/arm/arm-cores.def. (install-plugin): Install c-family headers into a c-family subdir. * config.gcc: Add vxworks-dummy.h to tm_file for arm, mips, sh and sparc targets. --- gcc/Makefile.in +++ gcc/Makefile.in @@ -4503,6 +4503,7 @@ $(EXCEPT_H) tree-ssa-sccvn.h real.h output.h $(IPA_UTILS_H) \ $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \ cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \ + config/arm/arm-cores.def \ $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h # generate the 'build fragment' b-header-vars @@ -4527,7 +4528,7 @@ else continue; \ fi; \ case $$path in \ - "$(srcdir)"/config/* | "$(srcdir)"/*.def ) \ + "$(srcdir)"/config/* | "$(srcdir)"/c-family/* | "$(srcdir)"/*.def ) \ base=`echo "$$path" | sed -e "s|$$srcdirstrip/||"`;; \ *) base=`basename $$path` ;; \ esac; \ --- gcc/config.gcc +++ gcc/config.gcc @@ -467,6 +467,9 @@ fi tm_file="vxworks-dummy.h ${tm_file}" ;; +arm*-*-*|mips*-*-*|sh*-*-*|sparc*-*-*) + tm_file="vxworks-dummy.h ${tm_file}" + ;; esac # On a.out targets, we need to use collect2. --------------030508060506090409080805--