From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15071 invoked by alias); 27 Jun 2011 02:12:18 -0000 Received: (qmail 15062 invoked by uid 22791); 27 Jun 2011 02:12:17 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_MF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 27 Jun 2011 02:12:03 +0000 Received: (qmail 29904 invoked from network); 27 Jun 2011 02:12:02 -0000 Received: from unknown (HELO ?192.168.1.5?) (janisjo@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 Jun 2011 02:12:02 -0000 Message-ID: <4E07E7A8.5060005@codesourcery.com> Date: Mon, 27 Jun 2011 05:08:00 -0000 From: Janis Johnson User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 MIME-Version: 1.0 To: Mike Stump CC: Richard Earnshaw , "Joseph S. Myers" , "gcc-patches@gcc.gnu.org" Subject: Re: [testsuite] skip ARM neon-fp16 tests for other -mcpu values References: <4DEECB2D.9000403@codesourcery.com> <4DF15AAD.6090109@codesourcery.com> <4DF8AB4D.9040604@arm.com> <4DF954EE.30802@codesourcery.com> <9579E79E-0CFD-4B57-ADFB-5510EE95C872@comcast.net> In-Reply-To: <9579E79E-0CFD-4B57-ADFB-5510EE95C872@comcast.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg01954.txt.bz2 On 06/25/2011 04:56 PM, Mike Stump wrote: > On Jun 15, 2011, at 5:57 PM, Janis Johnson wrote: >> The bug was in my attempt to run the tests with other -mfpu values, so >> I'm very glad you caught that. I tried again, getting rid of the neon >> requirement along the way, and found a way to run the VFP fp16 tests >> with any of the fp16 values that Joseph listed. >> >> This patch renames *arm_neon_fp16* to *arm_fp16* and skips tests if the >> multilib does not support arm32, includes -mfpu that is not fp16, or >> includes -mfloat-abi=soft. If the multilib uses -mfpu= with an fp16 >> value then that is used, otherwise -mfpu=vfpv4 is used. Added flags >> include -mfloat-abi=softfp in case the default is "soft". > >> OK for trunk, and for 4.6 a few days later? > > Ok. Ok for 4.6. For 4.6, as also please ensure that the RMs don't have the branch locked down. I'm waiting until after the 4.6.1 release to move anything more to that branch. > General comment, I'm happy to have the front-end, target and library > maintainers review and approve the normal additions to the .exp files > to support testing their bits. Yep! Janis