public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Richard Henderson <rth@redhat.com>,
	       Jakub Jelinek <jakub@redhat.com>
Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
Date: Mon, 27 Jun 2011 15:16:00 -0000	[thread overview]
Message-ID: <4E089A88.60401@redhat.com> (raw)
In-Reply-To: <BANLkTik8ZOfWVUV7SV1ryQ=yJtUiCG+tqQ@mail.gmail.com>

On 06/26/2011 05:58 PM, H.J. Lu wrote:
> The current unwind library scheme provides only one unwind
> context and is backward compatible with multiple different unwind
> contexts from multiple unwind libraries:
>
> http://gcc.gnu.org/ml/gcc-patches/2006-12/msg01769.html
>
> My patch fixes UNITS_PER_WORD > sizeof (void *) and
> enforces single unwind context when backward compatibility
> isn't needed.

OK, there seem to be two things going on in this patch:

1) Handle registers larger than pointers.
2) Require that all code share a single copy of the unwinder.

For #2, how are you avoiding the issues Jakub describes in that message? 
  Isn't his scenario 2 still possible?  Are you deciding that it's 
better to abort at run-time in that case?

It seems to me that for targets newer than Jakub's patch we can 
hard-wire _Unwind_IsExtendedContext to true, but making further 
assumptions would be a mistake.

Then, if we're still trying to handle versioning, I think your earlier 
patch for #1 (r170716) that just changes the type of the reg array is a 
better way to go.  But that change should be dependent on a target macro 
to avoid ABI changes for existing targets.

Jason

  reply	other threads:[~2011-06-27 14:58 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-25 17:02 H.J. Lu
2011-06-25 23:34 ` Joseph S. Myers
2011-06-25 23:36   ` H.J. Lu
2011-06-26 20:06 ` Jason Merrill
2011-06-26 20:22   ` Jason Merrill
2011-06-26 21:45   ` H.J. Lu
2011-06-27  2:12     ` Jason Merrill
2011-06-27  3:17       ` H.J. Lu
2011-06-27 15:16         ` Jason Merrill [this message]
2011-06-28 19:25           ` H.J. Lu
2011-06-30 14:46             ` Jason Merrill
2011-06-30 14:53               ` H.J. Lu
2011-06-30 15:26                 ` Jason Merrill
2011-06-30 16:36                   ` H.J. Lu
2011-06-30 17:57                     ` H.J. Lu
2011-06-30 18:01                       ` H.J. Lu
2011-06-30 18:10                         ` Rainer Orth
2011-06-30 18:19                           ` H.J. Lu
2011-06-30 18:42                             ` Rainer Orth
2011-06-30 20:14                               ` H.J. Lu
2011-06-30 20:24                                 ` Richard Henderson
2011-06-30 21:51                                   ` H.J. Lu
2011-07-01  9:03                                     ` Rainer Orth
2011-07-01 12:51                                       ` H.J. Lu
2011-07-01 13:37                                         ` Rainer Orth
2011-07-01 13:42                                           ` H.J. Lu
2011-07-01 14:03                                             ` Rainer Orth
2011-07-01 14:06                                               ` H.J. Lu
2011-07-01 14:25                                                 ` Rainer Orth
2011-07-01 14:55                                                   ` H.J. Lu
2011-08-02 21:02                                     ` Jason Merrill
2011-08-02 22:27                                       ` H.J. Lu
2011-08-03 21:47                                         ` Jason Merrill
2011-06-30 20:59                               ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E089A88.60401@redhat.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=jakub@redhat.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).