From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30296 invoked by alias); 28 Jun 2011 08:46:45 -0000 Received: (qmail 30215 invoked by uid 22791); 28 Jun 2011 08:46:43 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (94.185.240.25) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 28 Jun 2011 08:46:27 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 28 Jun 2011 09:46:24 +0100 Received: from [10.1.67.34] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 28 Jun 2011 09:46:21 +0100 Message-ID: <4E0994DD.9090609@arm.com> Date: Tue, 28 Jun 2011 09:29:00 -0000 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-GB; rv:1.9.2.18) Gecko/20110616 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: Richard Henderson CC: Richard Henderson , GCC Patches , Ramana Radhakrishnan Subject: Re: [RFC, ARM] Convert thumb1 prologue completely to rtl References: <4DFCF630.4080908@twiddle.net> <4E04601B.6000402@arm.com> <4E08CC92.8000702@redhat.com> In-Reply-To: <4E08CC92.8000702@redhat.com> X-MC-Unique: 111062809462407801 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg02107.txt.bz2 On 27/06/11 19:31, Richard Henderson wrote: > On 06/24/2011 02:59 AM, Richard Earnshaw wrote: >> On 18/06/11 20:02, Richard Henderson wrote: >>> I couldn't find anything terribly tricky about the conversion. >>> >>> The existing push_mult pattern would service thumb1 with just >>> a tweak or two to the memory predicate and the length. >>> >>> The existing emit_multi_reg_push wasn't set up to handle a >>> complete switch of registers for unwind info. I thought about >>> trying to merge them, but thought chickened out. >>> >>> I havn't cleaned out the code that is now dead in thumb_pushpop. >>> I'd been thinking about maybe converting epilogues completely >>> to rtl as well, which would allow the function to be deleted >>> completely, rather than incrementally. >>> >>> I'm unsure what testing should be applied. I'm currently doing >>> arm-elf, which does at least have a thumb1 multilib, and uses >>> newlib so I don't have to fiddle with setting up a full native >>> cross environment. What else should be done? arm-eabi? >>> >> >> Testing this on arm-eabi is essential since this may affect C++ unwind >> table generation (I can't see any obvious problems, but you never know). >> >=20 > I've now tested the patch with both arm-elf and arm-eabi with > RUNTESTFLAGS=3D'--target_board=3Darm-sim{-mthumb}' with no regressions. >=20 > Ok to install? >=20 Yep, thanks. R. >=20 > r~ >=20