From: Georg-Johann Lay <avr@gjlay.de>
To: gcc-patches@gcc.gnu.org
Cc: Denis Chertykov <chertykov@gmail.com>,
"Eric B. Weddington" <eric.weddington@atmel.com>,
Anatoly Sokolov <aesok@post.ru>
Subject: Ping #1: [Patch, AVR]: Fix PR34734
Date: Tue, 28 Jun 2011 12:00:00 -0000 [thread overview]
Message-ID: <4E09B29D.50809@gjlay.de> (raw)
In-Reply-To: <4DFF4EFE.3080006@gjlay.de>
http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01462.html
Georg-Johann Lay wrote:
> PR34734 produces annoying, false warnings if __attribute__((progmem))
> is used in conjunction with C++. DECL_INITIAL is not yet set up in
> avr_handle_progmem_attribute.
>
> Johann
>
> PR target/34734
> * config/avr/avr.c (avr_handle_progmem_attribute): Move warning
> about uninitialized data attributed 'progmem' from here...
> (avr_encode_section_info): ...to this new function.
> (TARGET_ENCODE_SECTION_INFO): New define.
> (avr_section_type_flags): For data in ".progmem.data", remove
> section flag SECTION_WRITE.
avr_encode_section_info is good place to emit the warning:
DECL_INITIAL has stabilized for C++, the warning will appear even for
unused variables that will eventually be thrown away, and the warning
appears only once (new_decl_p).
Johann
next prev parent reply other threads:[~2011-06-28 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 13:46 Georg-Johann Lay
2011-06-28 12:00 ` Georg-Johann Lay [this message]
2011-06-28 13:58 ` Ping #1: " Denis Chertykov
2011-06-29 8:21 ` Georg-Johann Lay
2011-06-29 10:42 ` Denis Chertykov
2011-06-29 12:11 ` Georg-Johann Lay
2011-06-29 13:45 ` Weddington, Eric
2011-06-30 14:35 ` Georg-Johann Lay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E09B29D.50809@gjlay.de \
--to=avr@gjlay.de \
--cc=aesok@post.ru \
--cc=chertykov@gmail.com \
--cc=eric.weddington@atmel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).