From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30491 invoked by alias); 28 Jun 2011 10:53:41 -0000 Received: (qmail 30483 invoked by uid 22791); 28 Jun 2011 10:53:40 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mo-p00-ob.rzone.de (HELO mo-p00-ob.rzone.de) (81.169.146.160) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Jun 2011 10:53:27 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT2k715jHQaJercGObUOFkj18odoYNahU4Q== X-RZG-CLASS-ID: mo00 Received: from [192.168.0.22] (business-188-111-022-002.static.arcor-ip.net [188.111.22.2]) by post.strato.de (fruni mo2) (RZmta 25.18) with ESMTPA id Z05a92n5S97hQj ; Tue, 28 Jun 2011 12:53:17 +0200 (MEST) Message-ID: <4E09B29D.50809@gjlay.de> Date: Tue, 28 Jun 2011 12:00:00 -0000 From: Georg-Johann Lay User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Denis Chertykov , "Eric B. Weddington" , Anatoly Sokolov Subject: Ping #1: [Patch, AVR]: Fix PR34734 References: <4DFF4EFE.3080006@gjlay.de> In-Reply-To: <4DFF4EFE.3080006@gjlay.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg02120.txt.bz2 http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01462.html Georg-Johann Lay wrote: > PR34734 produces annoying, false warnings if __attribute__((progmem)) > is used in conjunction with C++. DECL_INITIAL is not yet set up in > avr_handle_progmem_attribute. > > Johann > > PR target/34734 > * config/avr/avr.c (avr_handle_progmem_attribute): Move warning > about uninitialized data attributed 'progmem' from here... > (avr_encode_section_info): ...to this new function. > (TARGET_ENCODE_SECTION_INFO): New define. > (avr_section_type_flags): For data in ".progmem.data", remove > section flag SECTION_WRITE. avr_encode_section_info is good place to emit the warning: DECL_INITIAL has stabilized for C++, the warning will appear even for unused variables that will eventually be thrown away, and the warning appears only once (new_decl_p). Johann