From: Jeff Law <law@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [patch] Fix oversight in tuplification of DOM
Date: Tue, 28 Jun 2011 22:18:00 -0000 [thread overview]
Message-ID: <4E0A4389.3090301@redhat.com> (raw)
In-Reply-To: <201106282236.53994.ebotcazou@adacore.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/28/11 14:36, Eric Botcazou wrote:
> Hi,
>
> the attached testcase triggers an ICE when compiled at -O or above, on all the
> open branches. This is a regression introduced with the tuplification. The
> problem is that 2 ARRAY_RANGE_REFs are recognized as equivalent, although they
> don't have the same number of elements. This is so because their type isn't
> taken into account by the hash equality function as it simply isn't recorded
> in initialize_hash_element (GIMPLE_SINGLE_RHS case). Now in all the other
> cases it is recorded so this very likely is an oversight.
>
> Tested on x86_64-suse-linux, OK for all branches?
>
>
> 2011-06-28 Eric Botcazou <ebotcazou@adacore.com>
>
> * tree-ssa-dom.c (initialize_hash_element): Fix oversight.
>
>
> 2011-06-28 Eric Botcazou <ebotcazou@adacore.com>
>
> * gnat.dg/opt17.ad[sb]: New test.
OK.
Jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJOCkOJAAoJEBRtltQi2kC7d74H/1UxVoJCRtAJyLBzwPvVCKni
7uowRbHYTWVpB5y+LrrrIh8vkcuM/SZ6LAB6SuowK00G+4zQJtmvnA9DBLq65WSZ
/vOiond3LljmH8E5m7lg9umx5VO7jdErScB7xORfEezNy4857Y0p78UOkZxKiDpI
RqKThfRYK/0mjizTlDaPaBQH/LIRJU8MgxWA8SDxLKZ1FmmqhOqcyH7Z+wbGdNPf
QoHAd5xrQsA7Ga3kmwI/eBjNqlKkWS92L0ggQnn6aKsJJNeDuLdfolFKw4Fi4waN
X8BV4vYDlDVywRoFRzo1lvBIjeJ9hpJsT3cLuW6Kp3BUvEzQjyv7d0o/BRxWYfw=
=lvG1
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-06-28 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 21:50 Eric Botcazou
2011-06-28 22:18 ` Jeff Law [this message]
2011-06-29 7:32 ` Hans-Peter Nilsson
2011-06-29 9:38 ` Richard Guenther
2011-06-30 20:47 ` Eric Botcazou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0A4389.3090301@redhat.com \
--to=law@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).