From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19050 invoked by alias); 28 Jun 2011 21:12:11 -0000 Received: (qmail 19039 invoked by uid 22791); 28 Jun 2011 21:12:10 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Jun 2011 21:11:52 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5SLBe32007524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 28 Jun 2011 17:11:40 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5SLBdBF005110; Tue, 28 Jun 2011 17:11:39 -0400 Received: from [10.3.113.109] (ovpn-113-109.phx2.redhat.com [10.3.113.109]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p5SLBcm4000546; Tue, 28 Jun 2011 17:11:39 -0400 Message-ID: <4E0A4389.3090301@redhat.com> Date: Tue, 28 Jun 2011 22:18:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Eric Botcazou CC: gcc-patches@gcc.gnu.org Subject: Re: [patch] Fix oversight in tuplification of DOM References: <201106282236.53994.ebotcazou@adacore.com> In-Reply-To: <201106282236.53994.ebotcazou@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg02174.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/28/11 14:36, Eric Botcazou wrote: > Hi, > > the attached testcase triggers an ICE when compiled at -O or above, on all the > open branches. This is a regression introduced with the tuplification. The > problem is that 2 ARRAY_RANGE_REFs are recognized as equivalent, although they > don't have the same number of elements. This is so because their type isn't > taken into account by the hash equality function as it simply isn't recorded > in initialize_hash_element (GIMPLE_SINGLE_RHS case). Now in all the other > cases it is recorded so this very likely is an oversight. > > Tested on x86_64-suse-linux, OK for all branches? > > > 2011-06-28 Eric Botcazou > > * tree-ssa-dom.c (initialize_hash_element): Fix oversight. > > > 2011-06-28 Eric Botcazou > > * gnat.dg/opt17.ad[sb]: New test. OK. Jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJOCkOJAAoJEBRtltQi2kC7d74H/1UxVoJCRtAJyLBzwPvVCKni 7uowRbHYTWVpB5y+LrrrIh8vkcuM/SZ6LAB6SuowK00G+4zQJtmvnA9DBLq65WSZ /vOiond3LljmH8E5m7lg9umx5VO7jdErScB7xORfEezNy4857Y0p78UOkZxKiDpI RqKThfRYK/0mjizTlDaPaBQH/LIRJU8MgxWA8SDxLKZ1FmmqhOqcyH7Z+wbGdNPf QoHAd5xrQsA7Ga3kmwI/eBjNqlKkWS92L0ggQnn6aKsJJNeDuLdfolFKw4Fi4waN X8BV4vYDlDVywRoFRzo1lvBIjeJ9hpJsT3cLuW6Kp3BUvEzQjyv7d0o/BRxWYfw= =lvG1 -----END PGP SIGNATURE-----