From: Jason Merrill <jason@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches@gcc.gnu.org, Richard Henderson <rth@redhat.com>,
Jakub Jelinek <jakub@redhat.com>
Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *)
Date: Thu, 30 Jun 2011 15:26:00 -0000 [thread overview]
Message-ID: <4E0C904E.8090504@redhat.com> (raw)
In-Reply-To: <BANLkTinOGKQCq2abZW0L7CLOQ901+Oodxg@mail.gmail.com>
On 06/30/2011 10:42 AM, H.J. Lu wrote:
> Register may be saved/restored either by address or value. My patch
> doesn't change the reg field. The other way will be
>
> #ifdef USE_UNWIND_WORD
> _Unwind_Word reg[DWARF_FRAME_REGISTERS+1];
> #else
> void *reg[DWARF_FRAME_REGISTERS+1];
> #endif
>
> We need it so that we are binary compatible with the existing
> unwind context. Once we do that we need many
>
> #ifdef USE_UNWIND_WORD
> #endif
>
> whenever the reg field is accessed since the reg field is changed.
But your patch already changes all but one place where reg is accessed.
And we can avoid lots of ifdefs by abstraction with macros/inlines so
there's one interface.
Also, why change SIGNAL_FRAME_BIT?
Jason
next prev parent reply other threads:[~2011-06-30 15:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 17:02 H.J. Lu
2011-06-25 23:34 ` Joseph S. Myers
2011-06-25 23:36 ` H.J. Lu
2011-06-26 20:06 ` Jason Merrill
2011-06-26 20:22 ` Jason Merrill
2011-06-26 21:45 ` H.J. Lu
2011-06-27 2:12 ` Jason Merrill
2011-06-27 3:17 ` H.J. Lu
2011-06-27 15:16 ` Jason Merrill
2011-06-28 19:25 ` H.J. Lu
2011-06-30 14:46 ` Jason Merrill
2011-06-30 14:53 ` H.J. Lu
2011-06-30 15:26 ` Jason Merrill [this message]
2011-06-30 16:36 ` H.J. Lu
2011-06-30 17:57 ` H.J. Lu
2011-06-30 18:01 ` H.J. Lu
2011-06-30 18:10 ` Rainer Orth
2011-06-30 18:19 ` H.J. Lu
2011-06-30 18:42 ` Rainer Orth
2011-06-30 20:14 ` H.J. Lu
2011-06-30 20:24 ` Richard Henderson
2011-06-30 21:51 ` H.J. Lu
2011-07-01 9:03 ` Rainer Orth
2011-07-01 12:51 ` H.J. Lu
2011-07-01 13:37 ` Rainer Orth
2011-07-01 13:42 ` H.J. Lu
2011-07-01 14:03 ` Rainer Orth
2011-07-01 14:06 ` H.J. Lu
2011-07-01 14:25 ` Rainer Orth
2011-07-01 14:55 ` H.J. Lu
2011-08-02 21:02 ` Jason Merrill
2011-08-02 22:27 ` H.J. Lu
2011-08-03 21:47 ` Jason Merrill
2011-06-30 20:59 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0C904E.8090504@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hjl.tools@gmail.com \
--cc=jakub@redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).