From: Diego Novillo <dnovillo@google.com>
To: Gabriel Charette <gchare@google.com>
Cc: reply@codereview.appspotmail.com, crowl@google.com,
gcc-patches@gcc.gnu.org
Subject: Re: [pph] Stream and restore static_aggregates (issue4626096)
Date: Wed, 06 Jul 2011 18:32:00 -0000 [thread overview]
Message-ID: <4E14A913.8010502@google.com> (raw)
In-Reply-To: <CAJTZ7LK_xkEj_gCAa6sL=H1-TRAysVqPgK3ov=NymhWzjy7uLQ@mail.gmail.com>
On 11-07-06 13:12 , Gabriel Charette wrote:
> I had removed these two lines because that pretty much does nothing (I
> think, at least removing them didn't make anything fail...)... When we
It started causing an ICE in the test case that I marked fixed and
others (because we now stream static_aggregates).
> Otherwise I agree we will need to modify
> pph_add_bindings_to_namespace. It is still missing the merge of
> "usings" and "using_directives". "static_decls" if I remember
> correctly were automatically reinserted when doing
> pushdecl_into_namespace for the static decls in "names".
Yeah. Jason suggests merging scope_chain->bindings read from the PPH
image into scope_chain->bindings from the translation unit. I've
started down that road. More later.
Diego.
prev parent reply other threads:[~2011-07-06 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 4:18 Diego Novillo
2011-07-06 17:17 ` Gabriel Charette
2011-07-06 18:32 ` Diego Novillo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E14A913.8010502@google.com \
--to=dnovillo@google.com \
--cc=crowl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gchare@google.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).