From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7680 invoked by alias); 6 Jul 2011 18:27:51 -0000 Received: (qmail 7669 invoked by uid 22791); 6 Jul 2011 18:27:50 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 18:27:37 +0000 Received: from hpaq13.eem.corp.google.com (hpaq13.eem.corp.google.com [172.25.149.13]) by smtp-out.google.com with ESMTP id p66IRZLs004855 for ; Wed, 6 Jul 2011 11:27:35 -0700 Received: from yxk30 (yxk30.prod.google.com [10.190.3.158]) by hpaq13.eem.corp.google.com with ESMTP id p66IQdoV020746 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 6 Jul 2011 11:27:34 -0700 Received: by yxk30 with SMTP id 30so122925yxk.25 for ; Wed, 06 Jul 2011 11:27:34 -0700 (PDT) Received: by 10.91.160.13 with SMTP id m13mr111328ago.168.1309976853953; Wed, 06 Jul 2011 11:27:33 -0700 (PDT) Received: from dhcp-172-29-42-20.tor.corp.google.com (dhcp-172-29-42-20.tor.corp.google.com [172.29.42.20]) by mx.google.com with ESMTPS id d8sm285599ana.15.2011.07.06.11.27.32 (version=SSLv3 cipher=OTHER); Wed, 06 Jul 2011 11:27:32 -0700 (PDT) Message-ID: <4E14A913.8010502@google.com> Date: Wed, 06 Jul 2011 18:32:00 -0000 From: Diego Novillo User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20110624 Thunderbird/5.0 MIME-Version: 1.0 To: Gabriel Charette CC: reply@codereview.appspotmail.com, crowl@google.com, gcc-patches@gcc.gnu.org Subject: Re: [pph] Stream and restore static_aggregates (issue4626096) References: <20110706040822.573AA1DA1D1@topo.tor.corp.google.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00386.txt.bz2 On 11-07-06 13:12 , Gabriel Charette wrote: > I had removed these two lines because that pretty much does nothing (I > think, at least removing them didn't make anything fail...)... When we It started causing an ICE in the test case that I marked fixed and others (because we now stream static_aggregates). > Otherwise I agree we will need to modify > pph_add_bindings_to_namespace. It is still missing the merge of > "usings" and "using_directives". "static_decls" if I remember > correctly were automatically reinserted when doing > pushdecl_into_namespace for the static decls in "names". Yeah. Jason suggests merging scope_chain->bindings read from the PPH image into scope_chain->bindings from the translation unit. I've started down that road. More later. Diego.