From: Tobias Burnus <burnus@net-b.de>
Cc: gcc patches <gcc-patches@gcc.gnu.org>, gfortran <fortran@gcc.gnu.org>
Subject: Re: [Patch, Fortran] Register allocatable coarrays.
Date: Wed, 06 Jul 2011 21:08:00 -0000 [thread overview]
Message-ID: <4E14CC3F.8060504@net-b.de> (raw)
In-Reply-To: <4E12CFB9.2060401@gmail.com>
Daniel Carrera wrote:
> On 07/05/2011 09:57 AM, Tobias Burnus wrote:
>> On 07/04/2011 11:34 PM, Daniel Carrera wrote:
>>> The test compiles, but there are "expected failures" because gcc
>>> doesn't think that allocatable scalar coarrays are supported. [...]
>>
>> I really don't want to add knowingly a failing test. Thus, either one
>> adds a test for allocatable array coarrays - or one simply relies on the
>> existing
>> gfortran.dg/coarray/{dummy_1.f90,image_index_1.f90,this_image_1.f90},
>> which allocate allocatable (array) coarrays.
>
> I vote for the second option. Rely on the existing tests. [...]
> Attached is an updated ChangeLog. And as I wrote above, it seems
> better to rely on the existing test cases than to duplicate a check
> for allocatable array coarrays.
>
> 2011-07-04 Daniel Carrera<dcarrera@gmail.com>
>
> * trans-array.c (gfc_array_allocate): Rename allocatable_array to
> allocatable. Rename function gfc_allocate_array_with_status to
> gfc_allocate_allocatable_with_status. Update function call for
> gfc_allocate_with_status.
> * trans-opemp.c (gfc_omp_clause_default_ctor): Rename function
> gfc_allocate_array_with_status to gfc_allocate_allocatable_with_status.
> * trans-stmt.c (gfc_trans_allocate): Update function call for
> gfc_allocate_with_status. Rename function gfc_allocate_array_with_status
> to gfc_allocate_allocatable_with_status.
> * trans.c (gfc_call_malloc): Add new parameter gfc_allocate_with_status
> so it uses the library for memory allocation when -fcoarray=lib.
> (gfc_allocate_allocatable_with_status): Renamed from
> gfc_allocate_array_with_status.
> (gfc_allocate_allocatable_with_status): Update function call for
> gfc_allocate_with_status.
> * trans.h (gfc_coarray_type): New enum.
> (gfc_allocate_with_status): Update prototype.
> (gfc_allocate_allocatable_with_status): Renamed from
> gfc_allocate_array_with_status.
> * trans-decl.c: Use the new constant GFC_CAF_COARRAY_ALLOC in the call
> to gfor_fndecl_caf_register.
Nit: There is a "(generate_coarray_sym_init)" missing in the
trans-decl.c entry.
Otherwise the patch is OK.
I have now committed it as Rev. 175937
Thanks for the patch!
Tobias
next parent reply other threads:[~2011-07-06 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4E1231EF.6050704@gmail.com>
[not found] ` <4E12C3F3.4070204@net-b.de>
[not found] ` <4E12CFB9.2060401@gmail.com>
2011-07-06 21:08 ` Tobias Burnus [this message]
2011-07-06 21:20 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E14CC3F.8060504@net-b.de \
--to=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).