From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14718 invoked by alias); 6 Jul 2011 20:57:58 -0000 Received: (qmail 14694 invoked by uid 22791); 6 Jul 2011 20:57:55 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MISSING_HEADERS,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mx02.qsc.de (HELO mx02.qsc.de) (213.148.130.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 20:57:39 +0000 Received: from [192.168.178.22] (port-92-204-30-62.dynamic.qsc.de [92.204.30.62]) by mx02.qsc.de (Postfix) with ESMTP id E825B1DFD0; Wed, 6 Jul 2011 22:57:36 +0200 (CEST) Message-ID: <4E14CC3F.8060504@net-b.de> Date: Wed, 06 Jul 2011 21:08:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.2.17) Gecko/20110414 SUSE/3.1.10 Thunderbird/3.1.10 MIME-Version: 1.0 CC: gcc patches , gfortran Subject: Re: [Patch, Fortran] Register allocatable coarrays. References: <4E1231EF.6050704@gmail.com> <4E12C3F3.4070204@net-b.de> <4E12CFB9.2060401@gmail.com> In-Reply-To: <4E12CFB9.2060401@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00404.txt.bz2 Daniel Carrera wrote: > On 07/05/2011 09:57 AM, Tobias Burnus wrote: >> On 07/04/2011 11:34 PM, Daniel Carrera wrote: >>> The test compiles, but there are "expected failures" because gcc >>> doesn't think that allocatable scalar coarrays are supported. [...] >> >> I really don't want to add knowingly a failing test. Thus, either one >> adds a test for allocatable array coarrays - or one simply relies on the >> existing >> gfortran.dg/coarray/{dummy_1.f90,image_index_1.f90,this_image_1.f90}, >> which allocate allocatable (array) coarrays. > > I vote for the second option. Rely on the existing tests. [...] > Attached is an updated ChangeLog. And as I wrote above, it seems > better to rely on the existing test cases than to duplicate a check > for allocatable array coarrays. > > 2011-07-04 Daniel Carrera > > * trans-array.c (gfc_array_allocate): Rename allocatable_array to > allocatable. Rename function gfc_allocate_array_with_status to > gfc_allocate_allocatable_with_status. Update function call for > gfc_allocate_with_status. > * trans-opemp.c (gfc_omp_clause_default_ctor): Rename function > gfc_allocate_array_with_status to gfc_allocate_allocatable_with_status. > * trans-stmt.c (gfc_trans_allocate): Update function call for > gfc_allocate_with_status. Rename function gfc_allocate_array_with_status > to gfc_allocate_allocatable_with_status. > * trans.c (gfc_call_malloc): Add new parameter gfc_allocate_with_status > so it uses the library for memory allocation when -fcoarray=lib. > (gfc_allocate_allocatable_with_status): Renamed from > gfc_allocate_array_with_status. > (gfc_allocate_allocatable_with_status): Update function call for > gfc_allocate_with_status. > * trans.h (gfc_coarray_type): New enum. > (gfc_allocate_with_status): Update prototype. > (gfc_allocate_allocatable_with_status): Renamed from > gfc_allocate_array_with_status. > * trans-decl.c: Use the new constant GFC_CAF_COARRAY_ALLOC in the call > to gfor_fndecl_caf_register. Nit: There is a "(generate_coarray_sym_init)" missing in the trans-decl.c entry. Otherwise the patch is OK. I have now committed it as Rev. 175937 Thanks for the patch! Tobias