From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4337 invoked by alias); 6 Jul 2011 23:36:30 -0000 Received: (qmail 4326 invoked by uid 22791); 6 Jul 2011 23:36:30 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jul 2011 23:36:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p66Na1Gj013469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jul 2011 19:36:01 -0400 Received: from anchor.twiddle.net (vpn-224-25.phx2.redhat.com [10.3.224.25]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p66Na0on007931; Wed, 6 Jul 2011 19:36:00 -0400 Message-ID: <4E14F160.3010906@redhat.com> Date: Wed, 06 Jul 2011 23:39:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc15 Thunderbird/3.1.10 MIME-Version: 1.0 To: Bernd Schmidt CC: GCC Patches Subject: Re: [11/11] Fix get_mode_bounds References: <4E0E0310.60406@codesourcery.com> <4E0E06EC.3050709@codesourcery.com> <4E14AB4C.4050703@redhat.com> <4E14EA0C.8010405@codesourcery.com> In-Reply-To: <4E14EA0C.8010405@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00418.txt.bz2 On 07/06/2011 04:04 PM, Bernd Schmidt wrote: > That might require target specific changes if there are assumptions that > a BImode value is either 0 or 1, not 0 or -1. For now I'd prefer to > minimize the impact. Systems that set STORE_FLAG_VALUE to -1: m68k spu Systems that use BImode: bfin ia64 mep sh rs6000 stormy16 There's no overlap. That said, I'm willing to approve the patch as-is. Certainly testing the signed-ness of the tree type seems preferable to just the mode, which can't tell signedness. r~