public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bernds@codesourcery.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>,
	 Jie Zhang <jzhang918@gmail.com>,
	rdsandiford@googlemail.com
Subject: Re: Generic hwloop support library
Date: Thu, 07 Jul 2011 15:47:00 -0000	[thread overview]
Message-ID: <4E15D455.5090709@codesourcery.com> (raw)
In-Reply-To: <g4k4bwedi7.fsf@googlemail.com>

On 07/05/11 21:25, Richard Sandiford wrote:

> (Could you bootstrap this on x86_64 to check for things like that?

That has no loop_end pattern so it wouldn't be much of a test, but a
x86_64 x bfin compiler has no warnings in this file with the intptr_t
thing fixed.

> A C bootstrap only should be fine of course, since the code isn't
> going to be run.)
> 
>> +  hwloop_info loops = NULL;
> 
> Unnecessary initialisation (or at least, it should be).

? The value is used inside the loop to initialize "next" of the first loop.

Committed with these changes (except the last).


Bernd

  reply	other threads:[~2011-07-07 15:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 13:55 Bernd Schmidt
2011-07-02 13:03 ` Richard Sandiford
2011-07-04 22:31   ` Bernd Schmidt
2011-07-05 19:36     ` Richard Sandiford
2011-07-07 15:47       ` Bernd Schmidt [this message]
2011-07-08  8:40         ` Richard Sandiford
2011-07-03 13:59 ` Steven Bosscher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E15D455.5090709@codesourcery.com \
    --to=bernds@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jzhang918@gmail.com \
    --cc=rdsandiford@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).