From: Tobias Burnus <burnus@net-b.de>
To: Daniel Carrera <dcarrera@gmail.com>
Cc: gfortran <fortran@gcc.gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: [Patch, Fortra] Add STAT_STOPPED_IMAGE to SYC ALL/SYNC IMAGES
Date: Sat, 09 Jul 2011 12:03:00 -0000 [thread overview]
Message-ID: <4E1838D7.4010102@net-b.de> (raw)
In-Reply-To: <4E1607CB.9050400@gmail.com>
Daniel Carrera wrote:
> I'd like to submit the attached patch. This patch was just discussed
> in the gfortran list. It fixes a couple of TODO items in the MPI
> library. It is a simple patch.
OK with the following nits fixed.
* As you have now an SVN account, can you add yourself to the
./MAINTAINERS file (section: "Write After Approval")? Don't forget to
write an email to gcc-patches@ with that patch after committal.
> libgfortran/ChangeLog
>
> 2011-07-07 Daniel Carrera <dcarrera@gmail.com>
>
> * mpi.c (_gfortran_caf_sync_all): Add STAT_STOPPED_IMAGE as a
> possible status value.
> (_gfortran_caf_sync_images): Ditto.
Change "mpi.c" to "caf/mpi.c" - the file name is relative to the
ChangeLog file.
> + char msg[30];
> + int len;
> +
> + if (caf_is_finalized)
> + len = snprintf (msg, 30, "ERROR: Image %d is stopped", caf_this_image);
> + else
> + len = snprintf (msg, 30, "SYNC ALL failed");
I would like to avoid magic numbers like "30"; in this case, one can
replace the 30 in snprintf by a simple "sizeof (msg)".
> + if (caf_is_finalized)
> + len = snprintf (msg, 30, "ERROR: Image %d is stopped", caf_this_image);
> + else
> + len = snprintf (msg, 30, "SYNC IMAGES failed");
Ditto.
Tobias
prev parent reply other threads:[~2011-07-09 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-07 19:29 Daniel Carrera
2011-07-09 12:03 ` Tobias Burnus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1838D7.4010102@net-b.de \
--to=burnus@net-b.de \
--cc=dcarrera@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).