public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Diego Novillo <dnovillo@google.com>
To: Gabriel Charette <gchare@google.com>
Cc: reply@codereview.appspotmail.com, crowl@google.com,
	       gcc-patches@gcc.gnu.org
Subject: Re: [pph] Stream DECL_CHAIN only for VAR/FUNCTION_DECLs that are part of a RECORD_OR_UNION_TYPE (issue4672055)
Date: Tue, 12 Jul 2011 23:26:00 -0000	[thread overview]
Message-ID: <4E1CCB76.3000309@google.com> (raw)
In-Reply-To: <CAJTZ7LKrunY0RfSnYJwC=Fa0M+TPHO6=G7NwHVJ4xb4qr56uPA@mail.gmail.com>

On 11-07-12 16:43 , Gabriel Charette wrote:

> Even if this doesn't break tests anymore, we probably still want this,
> no point adding stuff to the pph image that is not needed...

Actually, the reverse is true.  We want to write out the IL exactly as 
the original parser emitted it.  There are things we decide not to write 
because they are better re-generated when the pph image is being read 
(e.g., function numbers, DECL_RTL), but

> Any idea why lto doesn't call lto_output_chain, but simply
> lto_output_tree to output the chains for struct/union?

LTO did not need those chains because once in the middle-end they are 
not used.  We are working at the parser level, so we need them.  Perhaps 
we won't need to write these chains, but first I'd like to understand why.

Since we are streaming the chains backwards without new breakage, let's 
leave it out for now.


Diego.

  reply	other threads:[~2011-07-12 22:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-09 10:13 Gabriel Charette
2011-07-12 19:50 ` Diego Novillo
2011-07-12 20:56   ` Gabriel Charette
2011-07-12 23:26     ` Diego Novillo [this message]
2011-07-13  1:05       ` Gabriel Charette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1CCB76.3000309@google.com \
    --to=dnovillo@google.com \
    --cc=crowl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gchare@google.com \
    --cc=reply@codereview.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).