From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18486 invoked by alias); 14 Jul 2011 16:23:27 -0000 Received: (qmail 18478 invoked by uid 22791); 14 Jul 2011 16:23:25 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Jul 2011 16:23:12 +0000 Received: (qmail 2898 invoked from network); 14 Jul 2011 16:23:11 -0000 Received: from unknown (HELO ?84.152.205.52?) (bernds@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Jul 2011 16:23:11 -0000 Message-ID: <4E1F17EC.1090903@codesourcery.com> Date: Thu, 14 Jul 2011 16:30:00 -0000 From: Bernd Schmidt User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110708 Lightning/1.0b3pre Thunderbird/3.1.10 MIME-Version: 1.0 To: Richard Henderson CC: GCC Patches , Eric Botcazou , Steve Ellcey , "Vladimir N. Makarov" Subject: Re: Correct fix for scheduler bug PR11320 References: <4E1EBEFE.3080002@codesourcery.com> <4E1F135C.8080705@redhat.com> <4E1F1718.6000302@codesourcery.com> In-Reply-To: <4E1F1718.6000302@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg01180.txt.bz2 On 07/14/11 18:19, Bernd Schmidt wrote: > On 07/14/11 18:03, Richard Henderson wrote: >> On 07/14/2011 03:03 AM, Bernd Schmidt wrote: >>> +++ gcc/config/ia64/ia64.c (working copy) >>> @@ -1047,7 +1047,7 @@ >>> tmp = gen_rtx_PLUS (Pmode, tmp, pic_offset_table_rtx); >>> emit_insn (gen_rtx_SET (VOIDmode, dest, tmp)); >>> >>> - tmp = gen_rtx_LO_SUM (Pmode, dest, src); >>> + tmp = gen_rtx_LO_SUM (Pmode, gen_rtx_MEM (Pmode, dest), src); >> >> And the bug stems from ... what? >> >> Is this bug still fixed if you change this to gen_const_mem? > > It should be. Testing this isn't straightforward bit tricky since the > original bug is in gcc-3.3 which doesn't have gen_const_mem, and current > mainline with just the scheduler patch removed doesn't reproduce it with > the testcase. Ok, with gen_const_mem hacked into gcc-3.3 (minus setting MEM_READONLY_P which doesn't exist in that tree) the load stays behind the branch where it should be. Bernd