public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bernds@codesourcery.com>
To: Richard Earnshaw <Richard.Earnshaw@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [ARM] Fix PR49641
Date: Mon, 25 Jul 2011 17:00:00 -0000	[thread overview]
Message-ID: <4E2D9996.3060905@codesourcery.com> (raw)
In-Reply-To: <4E1DA543.4030000@arm.com>

On 07/13/11 16:01, Richard Earnshaw wrote:
> On 07/07/11 21:02, Bernd Schmidt wrote:
>> This corrects an error in store_multiple_operation. We're only
>> generating the writeback version of the instruction on Thumb-1, so
>> that's where we must make sure the base register isn't also stored.
>>
>> The ARMv7 manual is unfortunately not totally clear that this does in
>> fact produce unpredictable results; it seems to suggest that this is the
>> case only for the T2 encoding. Older documentation makes it clear.
>>
>> Tested on arm-eabi{,mthumb}.
>>
> 
> I agree that the wording here is unclear, but the pseudo code for the
> decode makes the situation clearer, and does reflect what I really
> believe to be the case.  Put explicitly:

[...]

I just remembered this patch. Your reply didn't actually comment on it,
so - ok to install?


bernd

      parent reply	other threads:[~2011-07-25 16:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 20:08 Bernd Schmidt
2011-07-13 14:31 ` Richard Earnshaw
2011-10-14 13:57   ` Bernd Schmidt
2011-10-17 13:34     ` Richard Earnshaw
2011-10-18 12:26       ` Bernd Schmidt
2011-10-18 12:59         ` Richard Earnshaw
2011-10-18 14:24           ` Bernd Schmidt
2011-10-18 14:26             ` Richard Earnshaw
2011-10-24 14:00               ` Sebastian Huber
2011-10-25 17:52                 ` Richard Earnshaw
2011-10-31 11:53                   ` Sebastian Huber
2011-11-08  8:35                     ` Sebastian Huber
2011-11-16 10:41                       ` Sebastian Huber
2011-11-16 19:05                         ` Richard Earnshaw
     [not found] ` <4E1DA543.4030000@arm.com>
2011-07-25 17:00   ` Bernd Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2D9996.3060905@codesourcery.com \
    --to=bernds@codesourcery.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).