From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6541 invoked by alias); 25 Jul 2011 23:55:38 -0000 Received: (qmail 6533 invoked by uid 22791); 25 Jul 2011 23:55:37 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Jul 2011 23:55:19 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6PNtJiV022306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Jul 2011 19:55:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6PNtI7Z016935; Mon, 25 Jul 2011 19:55:19 -0400 Received: from [0.0.0.0] (ovpn-113-48.phx2.redhat.com [10.3.113.48]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6PNtHZC010439; Mon, 25 Jul 2011 19:55:17 -0400 Message-ID: <4E2E0264.30909@redhat.com> Date: Tue, 26 Jul 2011 05:28:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110719 Thunderbird/5.0 MIME-Version: 1.0 To: Aldy Hernandez CC: Jeff Law , gcc-patches , Jakub Jelinek Subject: Re: [C++0x] contiguous bitfields race implementation References: <4DC8155A.3040401@redhat.com> <4DC82136.6030802@redhat.com> <4DC83549.8010709@redhat.com> <4DC83F49.5020101@redhat.com> <4DCD8412.9020005@redhat.com> <4DD440EA.2080500@redhat.com> <4DD5AA47.4000902@redhat.com> <4DDE8CE6.40203@redhat.com> <4DDE9040.8000807@redhat.com> <4DDE99D2.4020502@redhat.com> <4DDE9DED.6040801@redhat.com> <4DDFF90E.7070408@redhat.com> <4E2420E6.8090809@redhat.com> <4E29C502.8020100@redhat.com> <4E2DA2BA.1010003@redhat.com> In-Reply-To: <4E2DA2BA.1010003@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg02223.txt.bz2 On 07/25/2011 10:07 AM, Aldy Hernandez wrote: > I had changed this already to take into account aliasing, so if we get > an INDIRECT_REF, ptr_deref_may_alias_global_p() returns true, and we > proceed with the restriction: Sounds good. "global" includes malloc'd memory, right? There don't seem to be any tests for that. Speaking of tests, please put them in c-c++-common. > + bitnum -= bitregion_start; > + bitregion_end -= bitregion_start; > + bitregion_start = 0; Why is this necessary/useful? Jason