From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30797 invoked by alias); 30 Jul 2011 00:03:19 -0000 Received: (qmail 30789 invoked by uid 22791); 30 Jul 2011 00:03:19 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 30 Jul 2011 00:03:02 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6U02T6Z007364 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 29 Jul 2011 20:02:29 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6U02R2V028067; Fri, 29 Jul 2011 20:02:28 -0400 Received: from [0.0.0.0] (ovpn-113-45.phx2.redhat.com [10.3.113.45]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6U02OWf007693; Fri, 29 Jul 2011 20:02:25 -0400 Message-ID: <4E334A10.3020602@redhat.com> Date: Sat, 30 Jul 2011 06:20:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110719 Thunderbird/5.0 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, paolo@gnu.org Subject: Re: [PATCH 1/7] Linemap infrastructure for virtual locations References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <3d6fbfd16f0e3493839205de1266eaaa8dbb9c77.1310824121.git.dodji@redhat.com> In-Reply-To: <3d6fbfd16f0e3493839205de1266eaaa8dbb9c77.1310824121.git.dodji@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg02729.txt.bz2 On 07/16/2011 07:37 AM, Dodji Seketeli wrote: > +/* Returns the highest location [of a token resulting from macro > + expansion] encoded in this line table. */ > +#define LINEMAPS_MACRO_HIGHEST_LOCATION(SET) \ > + LINEMAPS_HIGHEST_LOCATION(SET, true) > + > +/* Returns the location of the begining of the highest line > + -- containing a token resulting from macro expansion -- encoded > + in the line table SET. */ > +#define LINEMAPS_MACRO_HIGHEST_LINE(SET) \ > + LINEMAPS_HIGHEST_LINE(SET, true) What is the use of these? The ordinary highest line/location are used for various things, but I can't think of a reason you would want the above, nor are they used in any of the patches. Maybe these should be in line_maps instead of maps_info? Jason