From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15754 invoked by alias); 1 Aug 2011 04:42:20 -0000 Received: (qmail 15746 invoked by uid 22791); 1 Aug 2011 04:42:19 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Aug 2011 04:41:58 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p714fQSB018631 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 1 Aug 2011 00:41:26 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p714fPPe010001; Mon, 1 Aug 2011 00:41:25 -0400 Received: from [0.0.0.0] ([10.3.113.4]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p714fLw6012268; Mon, 1 Aug 2011 00:41:22 -0400 Message-ID: <4E362E71.7040009@redhat.com> Date: Mon, 01 Aug 2011 04:42:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110719 Thunderbird/5.0 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, paolo@gnu.org Subject: Re: [PATCH 1/7] Linemap infrastructure for virtual locations References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <3d6fbfd16f0e3493839205de1266eaaa8dbb9c77.1310824121.git.dodji@redhat.com> In-Reply-To: <3d6fbfd16f0e3493839205de1266eaaa8dbb9c77.1310824121.git.dodji@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg00005.txt.bz2 On 07/16/2011 07:37 AM, Dodji Seketeli wrote: > -extern void linemap_init (struct line_maps *); > +void linemap_init (struct line_maps *); > > -/* Free a line map set. */ > -extern void linemap_free (struct line_maps *); > +/* Free a line map set. This should be called only if maps have NOT > + been allocated in garbage memory space. */ > +void linemap_free (struct line_maps *); > > /* Check for and warn about line_maps entered but not exited. */ > +void linemap_check_files_exited (struct line_maps *); > > -extern void linemap_check_files_exited (struct line_maps *); > +/* Returns TRUE if the line table set tracks token locations accross > + macro expansion, FALSE otherwise. */ > +bool linemap_tracks_macro_expansion_locs_p (struct line_maps *); > > /* Return a source_location for the start (i.e. column==0) of > - (physical) line TO_LINE in the current source file (as in the > - most recent linemap_add). MAX_COLUMN_HINT is the highest column > - number we expect to use in this line (but it does not change > - the highest_location). */ > - > -extern source_location linemap_line_start > + (physical) line TO_LINE in the current source file (as in the most > + recent linemap_add). MAX_COLUMN_HINT is the highest column number > + we expect to use in this line (but it does not change the > + highest_location). */ > +source_location linemap_line_start > (struct line_maps *set, linenum_type to_line, unsigned int max_column_hint); Apart from the added declaration, these changes seem like unnecessary churn; let's avoid reformatting unchanged comments and removing "extern" from declarations that are correct as they are. Jason