From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20792 invoked by alias); 2 Aug 2011 02:00:18 -0000 Received: (qmail 20780 invoked by uid 22791); 2 Aug 2011 02:00:17 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Aug 2011 01:59:54 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p721xj5l028870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 1 Aug 2011 21:59:45 -0400 Received: from pebble.twiddle.home (vpn-227-220.phx2.redhat.com [10.3.227.220]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p721xi8b030066; Mon, 1 Aug 2011 21:59:44 -0400 Message-ID: <4E375A10.7040400@redhat.com> Date: Tue, 02 Aug 2011 02:00:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110621 Fedora/3.1.11-1.fc14 Thunderbird/3.1.11 MIME-Version: 1.0 To: GCC Patches CC: bernds@codesourcery.com, avr@gjlay.de, iant@google.com, law@redhat.com Subject: Re: [RFC] Cleanup DW_CFA_GNU_args_size handling References: <4E36D44A.6020607@redhat.com> In-Reply-To: <4E36D44A.6020607@redhat.com> Content-Type: multipart/mixed; boundary="------------020606070209030003030501" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg00095.txt.bz2 This is a multi-part message in MIME format. --------------020606070209030003030501 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 546 Testing on h8300, newlib/libm/math/ef_j0.c revealed a crash. The problem is that PREV turned out to be unlinked when we came to fixup_args_size_notes (prev, PREV_INSN (next), INTVAL (XEXP (p, 0))); I'm not sure how this didn't previously crash at fixup_eh_region_note (insn, prev, next); Thanks to reload inheritance deleting insns out from under, I can't think of any other mechanism than to have a marker note before INSN that won't get deleted. Comments? r~ --------------020606070209030003030501 Content-Type: text/plain; name="commit-90060c3" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="commit-90060c3" Content-length: 2314 Y29tbWl0IDkwMDYwYzNlOTUwOGQzYmQwYzkzMGJhMTNjYmUzMjMwYzdlYTBi OGYKQXV0aG9yOiBSaWNoYXJkIEhlbmRlcnNvbiA8cnRoQHJlZGhhdC5jb20+ CkRhdGU6ICAgTW9uIEF1ZyAxIDE4OjQ3OjA0IDIwMTEgLTA3MDAKCiAgICBy ZWxvYWQ6IFdvcmsgYXJvdW5kIHJlbG9hZCBpbmhlcml0ZW5jZSBkZWxldGlu ZyBpbnNucy4KCmRpZmYgLS1naXQgYS9nY2MvcmVsb2FkMS5jIGIvZ2NjL3Jl bG9hZDEuYwppbmRleCAzMjMzNTgwLi5iYTZjZTM3IDEwMDY0NAotLS0gYS9n Y2MvcmVsb2FkMS5jCisrKyBiL2djYy9yZWxvYWQxLmMKQEAgLTQ1NDgsNyAr NDU0OCw3IEBAIHJlbG9hZF9hc19uZWVkZWQgKGludCBsaXZlX2tub3duKQog I2lmIGRlZmluZWQgKEFVVE9fSU5DX0RFQykKICAgaW50IGk7CiAjZW5kaWYK LSAgcnR4IHg7CisgIHJ0eCB4LCBtYXJrZXI7CiAKICAgbWVtc2V0IChzcGls bF9yZWdfcnR4LCAwLCBzaXplb2Ygc3BpbGxfcmVnX3J0eCk7CiAgIG1lbXNl dCAoc3BpbGxfcmVnX3N0b3JlLCAwLCBzaXplb2Ygc3BpbGxfcmVnX3N0b3Jl KTsKQEAgLTQ1NTksNiArNDU1OSwxMCBAQCByZWxvYWRfYXNfbmVlZGVkIChp bnQgbGl2ZV9rbm93bikKIAogICBzZXRfaW5pdGlhbF9lbGltX29mZnNldHMg KCk7CiAKKyAgLyogR2VuZXJhdGUgYSBtYXJrZXIgaW5zbiB0aGF0IHdlIHdp bGwgbW92ZSBhcm91bmQuICAqLworICBtYXJrZXIgPSBlbWl0X25vdGUgKE5P VEVfSU5TTl9ERUxFVEVEKTsKKyAgdW5saW5rX2luc25fY2hhaW4gKG1hcmtl ciwgbWFya2VyKTsKKwogICBmb3IgKGNoYWluID0gcmVsb2FkX2luc25fY2hh aW47IGNoYWluOyBjaGFpbiA9IGNoYWluLT5uZXh0KQogICAgIHsKICAgICAg IHJ0eCBwcmV2ID0gMDsKQEAgLTQ2MzEsNyArNDYzNSwxMCBAQCByZWxvYWRf YXNfbmVlZGVkIChpbnQgbGl2ZV9rbm93bikKIAkgICAgICBydHggbmV4dCA9 IE5FWFRfSU5TTiAoaW5zbik7CiAJICAgICAgcnR4IHA7CiAKKwkgICAgICAv KiA/Pz8gUFJFViBjYW4gZ2V0IGRlbGV0ZWQgYnkgcmVsb2FkIGluaGVyaXRh bmNlLgorCQkgV29yayBhcm91bmQgdGhpcyBieSBlbWl0dGluZyBhIG1hcmtl ciBub3RlLiAgKi8KIAkgICAgICBwcmV2ID0gUFJFVl9JTlNOIChpbnNuKTsK KwkgICAgICByZW9yZGVyX2luc25zX25vYmIgKG1hcmtlciwgbWFya2VyLCBw cmV2KTsKIAogCSAgICAgIC8qIE5vdyBjb21wdXRlIHdoaWNoIHJlbG9hZCBy ZWdzIHRvIHJlbG9hZCB0aGVtIGludG8uICBQZXJoYXBzCiAJCSByZXVzaW5n IHJlbG9hZCByZWdzIGZyb20gcHJldmlvdXMgaW5zbnMsIG9yIGVsc2Ugb3V0 cHV0CkBAIC00NjQ5LDYgKzQ2NTYsOSBAQCByZWxvYWRfYXNfbmVlZGVkIChp bnQgbGl2ZV9rbm93bikKIAkJIGFuZCB0aGF0IHdlIG1vdmVkIHRoZSBzdHJ1 Y3R1cmUgaW50bykuICAqLwogCSAgICAgIHN1YnN0X3JlbG9hZHMgKGluc24p OwogCisJICAgICAgcHJldiA9IFBSRVZfSU5TTiAobWFya2VyKTsKKwkgICAg ICB1bmxpbmtfaW5zbl9jaGFpbiAobWFya2VyLCBtYXJrZXIpOworCiAJICAg ICAgLyogQWRqdXN0IHRoZSBleGNlcHRpb24gcmVnaW9uIG5vdGVzIGZvciBs b2FkcyBhbmQgc3RvcmVzLiAgKi8KIAkgICAgICBpZiAoY2Z1bi0+Y2FuX3Ro cm93X25vbl9jYWxsX2V4Y2VwdGlvbnMgJiYgIUNBTExfUCAoaW5zbikpCiAJ CWZpeHVwX2VoX3JlZ2lvbl9ub3RlIChpbnNuLCBwcmV2LCBuZXh0KTsK --------------020606070209030003030501--