From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14407 invoked by alias); 2 Aug 2011 21:02:51 -0000 Received: (qmail 14397 invoked by uid 22791); 2 Aug 2011 21:02:49 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Aug 2011 21:02:35 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p72L2WrR025671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Aug 2011 17:02:33 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p72L2W0c023377; Tue, 2 Aug 2011 17:02:32 -0400 Received: from [0.0.0.0] ([10.3.113.4]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p72L2TJt019025; Tue, 2 Aug 2011 17:02:30 -0400 Message-ID: <4E3865E5.1020606@redhat.com> Date: Tue, 02 Aug 2011 21:02:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110719 Thunderbird/5.0 MIME-Version: 1.0 To: "H.J. Lu" CC: Richard Henderson , Rainer Orth , gcc-patches@gcc.gnu.org, Jakub Jelinek Subject: Re: PATCH [8/n]: Prepare x32: PR other/48007: Unwind library doesn't work with UNITS_PER_WORD > sizeof (void *) References: <20110625161357.GA5401@intel.com> <4E078E58.20903@redhat.com> <4E07A879.70509@redhat.com> <4E089A88.60401@redhat.com> <4E0C8361.5050403@redhat.com> <4E0C904E.8090504@redhat.com> <4E0CC85E.3090401@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg00234.txt.bz2 On 06/30/2011 04:47 PM, H.J. Lu wrote: > +@defmac REG_VALUE_IN_UNWIND_CONTEXT > + > +Define this macro if the target stores register values as > +@code{_Unwind_Word} type in unwind context. The default is to > +store register values as @code{void *} type. > + > +@end defmac This ought to suggest why a port would need to do this, namely if registers can be larger than void*. > +#ifdef REG_VALUE_IN_UNWIND_CONTEXT > +typedef _Unwind_Word _Unwind_Context_Reg_Val; > + > +#define _Unwind_IsExtendedContext(c) 1 I still think that assuming extended context should be a separate target macro which is implied by REG_VALUE_IN_UNWIND_CONTEXT, but can also be defined separately by new ports. Otherwise it looks good to me. Jason