From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9210 invoked by alias); 5 Aug 2011 17:26:47 -0000 Received: (qmail 9176 invoked by uid 22791); 5 Aug 2011 17:26:45 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Aug 2011 17:26:32 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p75HPkJE021736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 5 Aug 2011 13:25:46 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p75HPkul010331; Fri, 5 Aug 2011 13:25:46 -0400 Received: from [0.0.0.0] (ovpn-113-87.phx2.redhat.com [10.3.113.87]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p75HPgkS019300; Fri, 5 Aug 2011 13:25:43 -0400 Message-ID: <4E3C2796.7070708@redhat.com> Date: Fri, 05 Aug 2011 17:31:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110719 Thunderbird/5.0 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, bonzini@gnu.org Subject: Re: [PATCH 1/7] Linemap infrastructure for virtual locations References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <3d6fbfd16f0e3493839205de1266eaaa8dbb9c77.1310824121.git.dodji@redhat.com> <4E378168.2090903@redhat.com> <4E3B0F24.90708@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg00623.txt.bz2 On 08/05/2011 01:04 PM, Dodji Seketeli wrote: > Jason Merrill writes: >> >> Why not 0xFFFFFFFF? I'm not sure what the rationale for using that >> value here: >> >>> /* If the column number is ridiculous or we've allocated a huge >>> number of source_locations, give up on column numbers. */ >>> max_column_hint = 0; >>> - if (highest>0xF0000000) >>> + if (highest> MAX_SOURCE_LOCATION) >>> return 0; >> >> was, but I would think that we would be fine to use that upper range >> for macro maps. > > I have no idea where the 0xF0000000 comes from. I have now set it to > 0xFFFFFFFF and it passed bootstrap + tests fine. Sorry, I should have been clearer; I think we want to leave this test alone so that ordinary locations don't grow past 0xF0000000, leaving the top range for macro locations. Jason