From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2045 invoked by alias); 22 Aug 2011 18:33:08 -0000 Received: (qmail 2037 invoked by uid 22791); 22 Aug 2011 18:33:07 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Aug 2011 18:32:54 +0000 Received: from wpaz17.hot.corp.google.com (wpaz17.hot.corp.google.com [172.24.198.81]) by smtp-out.google.com with ESMTP id p7MIWq2i011361 for ; Mon, 22 Aug 2011 11:32:52 -0700 Received: from gxk28 (gxk28.prod.google.com [10.202.11.28]) by wpaz17.hot.corp.google.com with ESMTP id p7MIWokj010503 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 22 Aug 2011 11:32:50 -0700 Received: by gxk28 with SMTP id 28so5952048gxk.27 for ; Mon, 22 Aug 2011 11:32:50 -0700 (PDT) Received: by 10.101.213.23 with SMTP id p23mr2657730anq.126.1314037970643; Mon, 22 Aug 2011 11:32:50 -0700 (PDT) Received: by 10.101.213.23 with SMTP id p23mr2657720anq.126.1314037970390; Mon, 22 Aug 2011 11:32:50 -0700 (PDT) Received: from dhcp-172-29-42-217.tor.corp.google.com (dhcp-172-29-42-217.tor.corp.google.com [172.29.42.217]) by mx.google.com with ESMTPS id j30sm5439450ann.48.2011.08.22.11.32.49 (version=SSLv3 cipher=OTHER); Mon, 22 Aug 2011 11:32:49 -0700 (PDT) Message-ID: <4E52A0DE.9050107@google.com> Date: Mon, 22 Aug 2011 19:00:00 -0000 From: Diego Novillo User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: Gabriel Charette CC: reply@codereview.appspotmail.com, crowl@google.com, gcc-patches@gcc.gnu.org Subject: Re: [pph] Cleanup line_table and includes streaming (issue4921052) References: <20110822182040.9C95C1C170F@gchare.mtv.corp.google.com> In-Reply-To: <20110822182040.9C95C1C170F@gchare.mtv.corp.google.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg01813.txt.bz2 On 11-08-22 14:20 , Gabriel Charette wrote: > 2011-08-22 Gabriel Charette > > * pph-streamer-in.c (pph_loc_offset): Add FIXME to move this variable > to pph_stream.encoder.r > (pph_in_include): New. > (pph_in_line_table_and_includes): Remove LINETAB parameter. Update > all users to use global LINE_TABLE instead. > Remove code moved to new function pph_in_include. And call it. > (pph_read_file_1): Remove extra parameter in call to > pph_in_line_table_and_includes. > * pph-streamer-out.c (pph_out_include): New. > (pph_get_next_include): Fix comment. > (pph_out_line_table_and_includes): Remove LINETAB parameter. Update > all users to use global LINE_TABLE instead. > Remove code moved to new function pph_out_include. And call it. > * gcc/cp/pph-streamer.h (pph_stream): Fix indenting. OK. Diego.