From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22767 invoked by alias); 23 Aug 2011 14:56:48 -0000 Received: (qmail 22755 invoked by uid 22791); 23 Aug 2011 14:56:47 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Aug 2011 14:56:27 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7NEuRkl026422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 23 Aug 2011 10:56:27 -0400 Received: from [127.0.0.1] (ovpn-113-47.phx2.redhat.com [10.3.113.47]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7NEuQYJ001574; Tue, 23 Aug 2011 10:56:27 -0400 Message-ID: <4E53BF9A.6060407@redhat.com> Date: Tue, 23 Aug 2011 15:39:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110719 Thunderbird/5.0 MIME-Version: 1.0 To: Siddhesh Poyarekar CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] PR c++/50055: Location information for the throw() specification in a function may be incorrect References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg01901.txt.bz2 On 08/12/2011 03:18 PM, Siddhesh Poyarekar wrote: > When the location for throw() exception specification is not the same > as the function it is written against, it leads gcov to give incorrect > results. See bug 50055 for details of the the same. The following > patch makes sure that the exception specification block (nothrow or > otherwise) is always associated with the function definition line > number. I'm applying this patch, thanks. This patch is small enough not to need it, but for future contributions please file a copyright assignment with the FSF. Send email to assign@gnu.org for more information. Jason