On 09/02/11 12:35, Ramana Radhakrishnan wrote:
> On 1 September 2011 12:50, Bernd Schmidt <bernds@codesourcery.com> wrote:
>> Shrink-wrapping tests on ARM had one additional failure, which I could
>> track down to a stmfd instruction being emitted where an stmhifd was
>> intended. The following patch fixes the testcase; full tests running
>> now. Ok?
> 
> IIUC this should have been a result of conditionalizing the prologue
> saves by the CCFSM state machine in ARM state

Correct.

> given that the push
> instruction below doesn't have the conditional markers.

Although I'm not sure how you arrived at this? Thumb insns can't be
conditional anyway?

>  In which case
> the routines to emit the asm for the VFP registers( vfp_output_fstmfd?
> ) should also be checked for this issue.

Hmm, ok. I found two more places which looked suspicious. New version,
untested so far. What's "sfmfd"? That doesn't occur in my manual.


Bernd