From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26823 invoked by alias); 7 Sep 2011 19:24:48 -0000 Received: (qmail 26813 invoked by uid 22791); 7 Sep 2011 19:24:46 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Sep 2011 19:24:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p87JO2rH029915 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 7 Sep 2011 15:24:02 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p87JO0pp015091; Wed, 7 Sep 2011 15:24:00 -0400 Received: from [0.0.0.0] (ovpn-113-157.phx2.redhat.com [10.3.113.157]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p87JNugV005992; Wed, 7 Sep 2011 15:23:56 -0400 Message-ID: <4E67C4CC.2010605@redhat.com> Date: Wed, 07 Sep 2011 19:26:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0) Gecko/20110817 Thunderbird/6.0 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, bonzini@gnu.org Subject: Re: [PATCH 1/7] Linemap infrastructure for virtual locations References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <3d6fbfd16f0e3493839205de1266eaaa8dbb9c77.1310824121.git.dodji@redhat.com> <4E378168.2090903@redhat.com> <4E3B0F24.90708@redhat.com> <4E3C2796.7070708@redhat.com> <4E4DE0BE.2020902@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00523.txt.bz2 On 09/01/2011 06:36 AM, Dodji Seketeli wrote: > +#ifdef ENABLE_CHECKING > + > +/* Assertion macro to be used in line-map code. */ > +#define linemap_assert(EXPR) \ > + do { \ > + if (! (EXPR)) \ > + abort (); \ > + } while (0) > + > +/* Assert that MAP encodes locations of tokens that are not part of > + the replacement-list of a macro expansion. */ > +#define linemap_check_ordinary(LINE_MAP) __extension__ \ > + ({linemap_assert (!linemap_macro_expansion_map_p (LINE_MAP)); \ > + (LINE_MAP);}) If you're going to use a statement-expression, you need to check that you're being compiled with GCC; tree.h uses #if defined ENABLE_TREE_CHECKING && (GCC_VERSION >= 2007) > - if (highest >0xF0000000) > + if (highest > 0xF0000000) Unnecessary whitespace change. OK with those changes. Jason