From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25103 invoked by alias); 9 Sep 2011 05:19:24 -0000 Received: (qmail 25094 invoked by uid 22791); 9 Sep 2011 05:19:22 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Sep 2011 05:19:07 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p895IfL9023575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Sep 2011 01:18:41 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p895IdkF021171; Fri, 9 Sep 2011 01:18:40 -0400 Received: from [0.0.0.0] (ovpn-113-157.phx2.redhat.com [10.3.113.157]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p895Iapu030351; Fri, 9 Sep 2011 01:18:36 -0400 Message-ID: <4E69A1AB.60200@redhat.com> Date: Fri, 09 Sep 2011 07:45:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, bonzini@gnu.org Subject: Re: [PATCH 1/7] Linemap infrastructure for virtual locations References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <3d6fbfd16f0e3493839205de1266eaaa8dbb9c77.1310824121.git.dodji@redhat.com> <4E378168.2090903@redhat.com> <4E3B0F24.90708@redhat.com> <4E3C2796.7070708@redhat.com> <4E4DE0BE.2020902@redhat.com> <4E67C4CC.2010605@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00609.txt.bz2 On 09/08/2011 06:32 AM, Dodji Seketeli wrote: > I have a question about this. It seems to me that adding the whitespace > there improves the consistency of the code base, and I thought that it > was allowed to make those changes if there are tangent to other > meaningful changes done in that area. If even that is not allowed, then > does that mean that such whitespace nits in the code base can never be > fixed? I am not willing to argue over that change, I am just trying to > understand. I usually only fix whitespace issues when I'm already changing something else on that line; I like to keep a patch specific to what it's actually fixing. For other whitespace issues I'd put them in a separate patch. But other people may feel differently about this question. Jason