From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22240 invoked by alias); 12 Sep 2011 21:54:07 -0000 Received: (qmail 22229 invoked by uid 22791); 12 Sep 2011 21:54:07 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Sep 2011 21:53:38 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8CLrD66005983 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 12 Sep 2011 17:53:13 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p8CLrCnj001758; Mon, 12 Sep 2011 17:53:13 -0400 Received: from [0.0.0.0] (ovpn-113-157.phx2.redhat.com [10.3.113.157]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p8CLrAdp004059; Mon, 12 Sep 2011 17:53:10 -0400 Message-ID: <4E6E7F45.1020306@redhat.com> Date: Mon, 12 Sep 2011 22:09:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, paolo@gnu.org Subject: Re: [PATCH 6/7] Kill pedantic warnings on system headers macros References: <1291979498-1604-1-git-send-email-dodji@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg00751.txt.bz2 On 07/16/2011 10:37 AM, Dodji Seketeli wrote: > + location_t here = c_parser_peek_token (parser)->location; Perhaps "first_token_loc"? It's unfortunate that we don't retain the locations of the individual declspecs, but I don't expect you to fix that. > + SYNTAX_ERROR2_AT (prev_virtual_location, > + "missing binary operator before token \"%s\"", > + cpp_token_as_text (pfile, op.token)); It seems to me that the "missing X before" errors should point to the current token, not the previous one. So you can drop prev_virtual_location. Jason