From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20105 invoked by alias); 17 Sep 2011 22:05:45 -0000 Received: (qmail 20097 invoked by uid 22791); 17 Sep 2011 22:05:44 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 17 Sep 2011 22:05:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8HM51r6031865 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 17 Sep 2011 18:05:01 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p8HM4xJA027165; Sat, 17 Sep 2011 18:05:00 -0400 Received: from [0.0.0.0] (ovpn-113-36.phx2.redhat.com [10.3.113.36]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p8HM4udZ024885; Sat, 17 Sep 2011 18:04:56 -0400 Message-ID: <4E751987.4060104@redhat.com> Date: Sat, 17 Sep 2011 22:34:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, bonzini@gnu.org Subject: Re: [PATCH 6/7] Kill pedantic warnings on system headers macros References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <4E6E7F45.1020306@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01030.txt.bz2 On 09/16/2011 04:46 AM, Dodji Seketeli wrote: > struct c_declspecs * > -finish_declspecs (struct c_declspecs *specs) > +finish_declspecs (struct c_declspecs *specs, > + location_t where) Let's call this first_token_loc, too. And mention it in the function comment. OK with that change. Jason