From: Jason Merrill <jason@redhat.com>
To: "Fabien Chêne" <fabien.chene@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch] PR c++/26256
Date: Tue, 20 Sep 2011 01:53:00 -0000 [thread overview]
Message-ID: <4E77D811.5000701@redhat.com> (raw)
In-Reply-To: <CAFH4-di=DitSxtnhTM4cv_vgNchvgA2v42q=7xdxqxusKcEDbw@mail.gmail.com>
On 09/17/2011 09:44 AM, Fabien Chêne wrote:
> I tried various things without success, and I ended up hacking
> supplement_binding_1 to handle those ENUMERAL_TYPEs.
> I am all ear for another solution ...
Your solution seems reasonable to me, but it needs a comment, along the
lines of
/* We allow pushing an enum multiple times in a class template in order
to handle late matching of underlying type on an opaque-enum-declaration
followed by an enum-specifier. */
And I guess limit it to dependent class scope. Incidentally, repeating
opaque-enum-declarations at class scope is invalid under 9.2/1:
--
A member shall not be declared twice in the member-specification, except
that a nested class or member class template can be declared and then
later defined, and except that an enumeration can be introduced with an
opaque-enum-declaration and later redeclared with an enum-specifier.
--
So
struct A
{
enum E: int;
enum E: int { e1 };
};
is OK, but
struct B
{
enum E: int;
enum E: int;
};
is not.
> +static tree
> +strip_using_decl (tree decl)
Needs a comment. Also, this function has a loop in it, but various
other places in the patch that look through USING_DECLs don't loop.
> if (!DECL_DEPENDENT_P (field))
> - continue;
> + {
> + tree using_decl = USING_DECL_DECLS (field);
> + if ((TREE_CODE (using_decl) == FIELD_DECL
> + || TREE_CODE (using_decl) == TYPE_DECL)
> + && DECL_NAME (using_decl) == name)
> + return using_decl;
> + continue;
> + }
This section needs a comment. Why do we look through USING_DECL for
these two kinds of member but not others?
next prev parent reply other threads:[~2011-09-20 0:02 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 19:44 Fabien Chêne
2010-05-16 19:20 ` Fabien Chêne
2010-06-08 21:50 ` Jason Merrill
2010-06-09 9:23 ` Fabien Chêne
2010-06-09 9:23 ` Fabien Chêne
2010-06-09 12:17 ` Jason Merrill
2010-06-16 21:21 ` Fabien Chêne
2010-06-17 8:39 ` Fabien Chêne
2010-06-18 8:18 ` Jason Merrill
2010-07-30 13:42 ` Fabien Chêne
2010-08-18 19:29 ` Fabien Chêne
2010-08-20 23:29 ` Jason Merrill
2010-11-15 21:40 ` Fabien Chêne
2010-11-15 21:41 ` Fabien Chêne
2010-11-17 11:25 ` Fabien Chêne
2010-12-20 16:51 ` Fabien Chêne
2010-12-22 23:10 ` Jason Merrill
2011-03-04 8:11 ` Fabien Chêne
2011-03-05 20:07 ` Jason Merrill
2011-03-08 21:48 ` Fabien Chêne
2011-06-15 19:42 ` Fabien Chêne
2011-06-22 15:56 ` Jason Merrill
2011-09-17 18:49 ` Fabien Chêne
2011-09-20 1:53 ` Jason Merrill [this message]
2011-09-21 18:33 ` Fabien Chêne
2011-09-21 18:52 ` Fabien Chêne
2011-09-21 19:01 ` Jason Merrill
2011-09-22 10:34 ` Fabien Chêne
2011-09-22 16:50 ` Jason Merrill
2011-09-22 23:01 ` Fabien Chêne
2011-09-22 23:48 ` Jason Merrill
2011-09-23 8:57 ` Fabien Chêne
2011-09-25 20:49 ` Fabien Chêne
2011-09-25 21:05 ` Paolo Carlini
2011-09-25 21:48 ` Fabien Chêne
2011-09-25 22:35 ` Paolo Carlini
2011-09-26 1:28 ` Fabien Chêne
2011-09-26 14:28 ` Jason Merrill
2011-10-10 20:35 ` Fabien Chêne
2011-10-11 15:35 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E77D811.5000701@redhat.com \
--to=jason@redhat.com \
--cc=fabien.chene@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).