From: Richard Henderson <rth@redhat.com>
To: Bernd Schmidt <bernds@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Handle multi-word regsiters in REG_CFA_RESTORE notes
Date: Wed, 21 Sep 2011 17:47:00 -0000 [thread overview]
Message-ID: <4E7A2004.8080603@redhat.com> (raw)
In-Reply-To: <4E79FAD7.8000908@codesourcery.com>
On 09/21/2011 07:55 AM, Bernd Schmidt wrote:
> On 09/15/11 21:42, Richard Henderson wrote:
>> On 09/14/2011 06:12 PM, Bernd Schmidt wrote:
>>> + unsigned int orig_regno = REGNO (reg);
>>> + int nregs = hard_regno_nregs[orig_regno][GET_MODE (reg)];
>>> + while (nregs-- > 0)
>>
>> The rest of the file seems to use targetm.dwarf_register_span.
>> This probably ought to do the same.
>
> I guess I am confused what dwarf_register_span is supposed to accomplish
> that a loop over nregs couldn't. For little endian MIPS, it returns
> NULL, so I don't think it would solve the problem I'm trying to fix.
Why, then, is this the only place in dwarf2cfi that needs to handle
registers via a loop over nregs? It seems to me that we should either
be handling multi-register spans everywhere or nowhere.
Because alternately, this could be a bug in your backend that you
failed to add two RESTORE notes instead of just one...
r~
next prev parent reply other threads:[~2011-09-21 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 2:42 Bernd Schmidt
2011-09-15 20:41 ` Richard Henderson
2011-09-21 15:14 ` Bernd Schmidt
2011-09-21 17:47 ` Richard Henderson [this message]
2011-09-22 22:09 ` Bernd Schmidt
2011-09-25 19:54 ` Richard Sandiford
2011-09-27 12:57 ` Bernd Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7A2004.8080603@redhat.com \
--to=rth@redhat.com \
--cc=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).