From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27327 invoked by alias); 26 Sep 2011 20:46:40 -0000 Received: (qmail 27152 invoked by uid 22791); 26 Sep 2011 20:46:38 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Sep 2011 20:46:19 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8QKjrvd017875 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 26 Sep 2011 16:45:53 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p8QKjq4E020304; Mon, 26 Sep 2011 16:45:52 -0400 Received: from [0.0.0.0] ([10.3.113.3]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p8QKjnXs011534; Mon, 26 Sep 2011 16:45:49 -0400 Message-ID: <4E80E47C.305@redhat.com> Date: Mon, 26 Sep 2011 22:30:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, bonzini@gnu.org Subject: Re: [PATCH 3/7] Emit macro expansion related diagnostics References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <7ab852c58faea9efd81130c5a1ddc9e78b34bcc5.1310824121.git.dodji@redhat.com> <4E6E73F8.4030603@redhat.com> <4E74AA75.8090106@redhat.com> <4E778A26.1000707@redhat.com> <4E77ACA1.80205@redhat.com> <4E789C5B.20509@redhat.com> <4E793BF4.4010103@redhat.com> <4E7B497F.8060301@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01650.txt.bz2 On 09/26/2011 04:21 PM, Dodji Seketeli wrote: > Jason Merrill writes: > >> On 09/21/2011 02:32 PM, Dodji Seketeli wrote: >>> FWIW, I'd like the LRK_MACRO_PARM_REPLACEMENT name (or its >>> replacement. ha ha) to hint at the fact that it really has to do with >>> a token that is an /argument/ for a function-like macro. >> >> I disagree; arguments are the situation when the two locations differ, >> but this one (yI) is always the source location in the macro >> definition > > I think an interesting question to ask here is "the source location of > what exactly?". It's the source location of what we're currently looking at, which is a virtual token in the macro expansion. My point is that yI is always a source location, whereas xI may or may not be. > Would LRK_MACRO_DEFINITION_LOCATION be better then? :-) Yes. :) Jason