From: Richard Henderson <rth@redhat.com>
To: Georg-Johann Lay <avr@gjlay.de>
Cc: gcc-patches@gcc.gnu.org, Denis Chertykov <chertykov@gmail.com>,
Eric Weddington <eric.weddington@atmel.com>
Subject: Re: [Patch,AVR]: Clean-up some SP insns
Date: Tue, 27 Sep 2011 16:55:00 -0000 [thread overview]
Message-ID: <4E81F0D4.5090909@redhat.com> (raw)
In-Reply-To: <4E8181C2.5000706@gjlay.de>
On 09/27/2011 12:56 AM, Georg-Johann Lay wrote:
> * config/avr/avr-protos.h (avr_out_addto_sp): New prototype.
> * config/avr/avr.c (avr_out_addto_sp): New function.
> (adjust_insn_length): Handle ADJUST_LEN_ADDTO_SP.
> * config/avr/avr.md (adjust_len): Add "addto_sp".
> (*movhi_sp): Remove insn.
> (*addhi3_sp_R_pc2, *addhi3_sp_R_pc3): Merge to *addhi3_sp_R.
While this is a good cleanup by itself, and probably should be
applied by itself, I think a good followup would be to merge
the addhi3_sp_R pattern with the normal addhi3 pattern.
This should be fairly easy, given that both are handled via C
functions now.
r~
next prev parent reply other threads:[~2011-09-27 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 9:26 Georg-Johann Lay
2011-09-27 16:55 ` Richard Henderson [this message]
2011-09-27 21:30 ` Georg-Johann Lay
2011-10-05 10:09 ` Ping #1: " Georg-Johann Lay
2011-10-05 10:43 ` Denis Chertykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E81F0D4.5090909@redhat.com \
--to=rth@redhat.com \
--cc=avr@gjlay.de \
--cc=chertykov@gmail.com \
--cc=eric.weddington@atmel.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).