From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21039 invoked by alias); 27 Sep 2011 15:51:05 -0000 Received: (qmail 21028 invoked by uid 22791); 27 Sep 2011 15:51:04 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Sep 2011 15:50:48 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8RFojHx005399 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Sep 2011 11:50:45 -0400 Received: from anchor.twiddle.net (vpn-234-244.phx2.redhat.com [10.3.234.244]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p8RFoi5h016907; Tue, 27 Sep 2011 11:50:45 -0400 Message-ID: <4E81F0D4.5090909@redhat.com> Date: Tue, 27 Sep 2011 16:55:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Georg-Johann Lay CC: gcc-patches@gcc.gnu.org, Denis Chertykov , Eric Weddington Subject: Re: [Patch,AVR]: Clean-up some SP insns References: <4E8181C2.5000706@gjlay.de> In-Reply-To: <4E8181C2.5000706@gjlay.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01740.txt.bz2 On 09/27/2011 12:56 AM, Georg-Johann Lay wrote: > * config/avr/avr-protos.h (avr_out_addto_sp): New prototype. > * config/avr/avr.c (avr_out_addto_sp): New function. > (adjust_insn_length): Handle ADJUST_LEN_ADDTO_SP. > * config/avr/avr.md (adjust_len): Add "addto_sp". > (*movhi_sp): Remove insn. > (*addhi3_sp_R_pc2, *addhi3_sp_R_pc3): Merge to *addhi3_sp_R. While this is a good cleanup by itself, and probably should be applied by itself, I think a good followup would be to merge the addhi3_sp_R pattern with the normal addhi3 pattern. This should be fairly easy, given that both are handled via C functions now. r~