From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15173 invoked by alias); 28 Sep 2011 14:15:37 -0000 Received: (qmail 15160 invoked by uid 22791); 28 Sep 2011 14:15:35 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Sep 2011 14:15:14 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8SEEnJg022392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 28 Sep 2011 10:14:49 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p8SEEllI008634; Wed, 28 Sep 2011 10:14:47 -0400 Received: from [0.0.0.0] (ovpn-113-113.phx2.redhat.com [10.3.113.113]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p8SEEhEL012254; Wed, 28 Sep 2011 10:14:44 -0400 Message-ID: <4E832BD3.4020003@redhat.com> Date: Wed, 28 Sep 2011 14:49:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, bonzini@gnu.org Subject: Re: [PATCH 2/7] Generate virtual locations for tokens References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <4E6E65B2.2060909@redhat.com> <4E711F42.80802@redhat.com> <4E77ACFE.2080805@redhat.com> <4E7B673D.9050306@redhat.com> <4E80CDA7.10106@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01847.txt.bz2 On 09/27/2011 08:03 PM, Dodji Seketeli wrote: > Jason Merrill writes: > >> Yes, I was suggesting that you change that, since it's only used by >> _get_location, which can get the location from the pointer instead. > > Done. And then you should be able to drop the track_macro_exp_p field from macro_arg_token_iter, and instead check whether location_ptr is set. Jason