From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31427 invoked by alias); 29 Sep 2011 19:42:37 -0000 Received: (qmail 31419 invoked by uid 22791); 29 Sep 2011 19:42:36 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Sep 2011 19:42:18 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8TJfqlF001377 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 29 Sep 2011 15:41:52 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p8TJfo5E017879; Thu, 29 Sep 2011 15:41:51 -0400 Received: from [0.0.0.0] (ovpn-113-113.phx2.redhat.com [10.3.113.113]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p8TJflmY002286; Thu, 29 Sep 2011 15:41:47 -0400 Message-ID: <4E84C9FA.30604@redhat.com> Date: Thu, 29 Sep 2011 21:25:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, bonzini@gnu.org Subject: Re: [PATCH 3/7] Emit macro expansion related diagnostics References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <7ab852c58faea9efd81130c5a1ddc9e78b34bcc5.1310824121.git.dodji@redhat.com> <4E6E73F8.4030603@redhat.com> <4E74AA75.8090106@redhat.com> <4E778A26.1000707@redhat.com> <4E77ACA1.80205@redhat.com> <4E789C5B.20509@redhat.com> <4E793BF4.4010103@redhat.com> <4E7B497F.8060301@redhat.com> <4E80E47C.305@redhat.com> <4E83B6D5.5030907@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01969.txt.bz2 On 09/29/2011 01:19 PM, Dodji Seketeli wrote: > + For a token that is /not/ an argument for a parameter of a > + function-like macro, each yI is the spelling location of the Ith > + token of the replacement-list in the definition of the macro. > + "Spelling location" means the location of the place in the source > + where the token has been spelled. > + > + For a token that is an argument for a parameter P of a > + function-like macro, yI is the spelling location of P in the > + replacement-list of the macro. I think think this can be simpler: yI is the location of the token in the macro definition, either of the token itself or of a macro parameter that it replaces. > + In #2, there is a macro map for the expansion of PLUS. PLUS is The macro map doesn't seem to me to be in #2, but the expansion is. Let's reword that to "There is a macro map for the expansion of PLUS in #2". > + x0 is the virtual location for the argument token "1", > + and x2 is the virtual location for the argument token "2". */ Are they actually virtual in this case? I thought they would be the source locations in #2 since the expanding context isn't another macro. Jason