public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Koval, Julia" <julia.koval@intel.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
	Uros Bizjak <ubizjak@gmail.com>,
	Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: RE: [PATCH][X86] Fix rounding pattern similar to PR73350
Date: Mon, 12 Jun 2017 16:06:00 -0000	[thread overview]
Message-ID: <4E89A029A0F8D443B436A5167BA3C53F199568BF@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <CAMe9rOr_ij4cU+M1RjLA7Um30bpm_cwOrQxnhqQj9_kJpB9taw@mail.gmail.com>

I would like to, but as far as I know the only testcase possible is below, and as far as I know there is no possibility to use dg-error for runtime exceptions(Sorry, if I'm wrong). There are only 2 versions of the flag exception or no exception and the error is, when they are combined in CSE.

> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Monday, June 12, 2017 3:43 PM
> To: Koval, Julia <julia.koval@intel.com>
> Cc: GCC Patches <gcc-patches@gcc.gnu.org>; Uros Bizjak
> <ubizjak@gmail.com>; Kirill Yukhin <kirill.yukhin@gmail.com>
> Subject: Re: [PATCH][X86] Fix rounding pattern similar to PR73350
> 
> On Mon, Jun 12, 2017 at 6:21 AM, Koval, Julia <julia.koval@intel.com> wrote:
> > This is the same issue as PR73350 and PR80862 for disabling FP exceptions.
> >
> > gcc -O0 -mavx512f -mavx512er returns exception
> > gcc -O2 -mavx512f -mavx512er returns nan
> >
> > For this code:
> >
> > #include <stdio.h>
> > #include <math.h>
> > #include <x86intrin.h>
> > #include <limits.h>
> > #include <float.h>
> >
> > int main(int argc, char *argv[]) {
> >     __m512 a = _mm512_set1_ps((float) -1);
> >     __m512 b = _mm512_set1_ps((float) -1);
> >     _mm_setcsr( _MM_MASK_MASK &~
> >
> (_MM_MASK_OVERFLOW|_MM_MASK_INVALID|_MM_MASK_DIV_ZERO) );
> >     __m512 result1 = _mm512_rsqrt28_round_ps(a, _MM_FROUND_NO_EXC );
> >     printf("%d %d\n", _MM_FROUND_CUR_DIRECTION,
> _MM_FROUND_NO_EXC);
> >     __m512 result2 = _mm512_rsqrt28_round_ps(a,
> _MM_FROUND_CUR_DIRECTION);
> >
> >     printf("%g\n", result1[0] - result2[0]);
> >
> >     return 0;
> > }
> >
> > This patch fixes the issue.
> >
> > gcc/
> >         * config/i386/i386.c: Fix rounding expand for new pattern
> >         * config/i386/subst.md: Fix pattern (parallel -> unspec)
> >
> > Ok for trunk?
> >
> 
> Please include the testcase.
> 
> Thanks.
> 
> --
> H.J.

  reply	other threads:[~2017-06-12 16:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 13:21 Koval, Julia
2017-06-12 13:42 ` H.J. Lu
2017-06-12 16:06   ` Koval, Julia [this message]
2017-06-12 16:08     ` H.J. Lu
2017-06-12 16:18       ` Jakub Jelinek
2017-06-12 16:50         ` Koval, Julia
2017-06-13  8:08           ` Richard Biener
2017-06-13 11:37             ` Koval, Julia
2017-06-14  9:54               ` Uros Bizjak
2017-06-16  6:46                 ` Koval, Julia
2017-06-16  7:05                   ` Uros Bizjak
2017-06-20 18:26                     ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E89A029A0F8D443B436A5167BA3C53F199568BF@IRSMSX101.ger.corp.intel.com \
    --to=julia.koval@intel.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hjl.tools@gmail.com \
    --cc=kirill.yukhin@gmail.com \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).