[PATCH] Darwin, testsuite: -multiply_defined is obsolete

[PATCH] Darwin, testsuite: -multiply_defined is obsolete

[FX Coudert]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

With Xcode 15, gcc.dg/ssp-2.c fails due to a warning: -multiply_defined is obsolete

The patches ignores the warning when present.
OK to push?

FX


[-- Attachment #2: 0001-Darwin-testsuite-multiply_defined-is-obsolete.patch --]
[-- Type: application/octet-stream, Size: 967 bytes --]

From 6b13e32162adf9e4f552e09c46f1de531ffa8c05 Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Sat, 10 Feb 2024 15:52:44 +0100
Subject: [PATCH] Darwin, testsuite: -multiply_defined is obsolete

gcc/testsuite/ChangeLog:

	* gcc.dg/ssp-2.c: Ignore warning that
	-multiply_defined is obsolete
---
 gcc/testsuite/gcc.dg/ssp-2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gcc/testsuite/gcc.dg/ssp-2.c b/gcc/testsuite/gcc.dg/ssp-2.c
index 752fe5393f4..608ca300032 100644
--- a/gcc/testsuite/gcc.dg/ssp-2.c
+++ b/gcc/testsuite/gcc.dg/ssp-2.c
@@ -1,6 +1,7 @@
 /* { dg-do run { target native } } */
 /* { dg-options "-fstack-protector" } */
 /* { dg-options "-fstack-protector -Wl,-multiply_defined,suppress" { target *-*-darwin* } } */
+/* { dg-prune-output "-multiply_defined is obsolete" } */
 /* { dg-require-effective-target fstack_protector } */
 
 #include <stdlib.h>
-- 
2.39.3 (Apple Git-145)

Re: [PATCH] Darwin, testsuite: -multiply_defined is obsolete

[Iain Sandoe]

> On 10 Feb 2024, at 14:54, FX Coudert <fxcoudert@gmail.com> wrote:
> 
> With Xcode 15, gcc.dg/ssp-2.c fails due to a warning: -multiply_defined is obsolete
> 
> The patches ignores the warning when present.
> OK to push?

yes, thanks.
Iain

… although part of me is curious about whether we still have any supported
OS version for which the  “-multiply_defined,suppress” is needed, we should try
to put that evaluation on the GCC-15  TODO.

> 
> FX
> 
> <0001-Darwin-testsuite-multiply_defined-is-obsolete.patch>