From: Richard Henderson <rth@redhat.com>
To: Sameera Deshpande <sameera.deshpande@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"nickc@redhat.com" <nickc@redhat.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
"paul@codesourcery.com" <paul@codesourcery.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [RFA/ARM][Patch 02/05]: LDRD generation instead of POP in A15 Thumb2 epilogue.
Date: Thu, 13 Oct 2011 18:14:00 -0000 [thread overview]
Message-ID: <4E9720AA.20306@redhat.com> (raw)
In-Reply-To: <1318324917.2186.52.camel@e102549-lin.cambridge.arm.com>
On 10/11/2011 02:21 AM, Sameera Deshpande wrote:
> + /* When saved-register index (i) is odd, RTXs for both the registers
> + to be loaded are generated in above given LDRD pattern, and the
> + pattern can be emitted now. */
> + par = emit_insn (par);
> + add_reg_note (par, REG_FRAME_RELATED_EXPR, dwarf);
I don't believe REG_FRAME_RELATED_EXPR does the right thing for
anything besides prologues. You need to emit REG_CFA_RESTORE
for the pop inside an epilogue.
r~
next prev parent reply other threads:[~2011-10-13 17:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 9:22 [RFA/ARM][Patch 00/05]: Introduction - Generate LDRD/STRD in prologue/epilogue instead of PUSH/POP Sameera Deshpande
2011-10-11 9:31 ` [RFA/ARM][Patch 01/05]: Create tune for Cortex-A15 Sameera Deshpande
2011-10-21 12:56 ` Ramana Radhakrishnan
2011-10-11 9:38 ` [RFA/ARM][Patch 02/05]: LDRD generation instead of POP in A15 Thumb2 epilogue Sameera Deshpande
2011-10-13 18:14 ` Richard Henderson [this message]
2011-11-07 9:54 ` Sameera Deshpande
2011-11-07 16:59 ` Richard Henderson
2011-12-30 12:42 ` Sameera Deshpande
2011-10-11 9:53 ` [RFA/ARM][Patch 03/05]: STRD generation instead of PUSH in A15 Thumb2 prologue Sameera Deshpande
2011-10-21 13:00 ` Ramana Radhakrishnan
2011-11-07 9:55 ` Sameera Deshpande
2011-10-11 10:12 ` [RFA/ARM][Patch 04/05]: STRD generation instead of PUSH in A15 ARM prologue Sameera Deshpande
2011-10-21 13:21 ` Ramana Radhakrishnan
2011-11-08 11:14 ` Sameera Deshpande
2011-10-11 10:19 ` [RFA/ARM][Patch 05/05]: LDRD generation instead of POP in A15 ARM epilogue Sameera Deshpande
2011-10-21 13:30 ` Ramana Radhakrishnan
2011-11-08 11:15 ` Sameera Deshpande
2011-12-30 13:29 ` Sameera Deshpande
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9720AA.20306@redhat.com \
--to=rth@redhat.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nickc@redhat.com \
--cc=paul@codesourcery.com \
--cc=sameera.deshpande@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).