From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13766 invoked by alias); 13 Oct 2011 17:32:58 -0000 Received: (qmail 13756 invoked by uid 22791); 13 Oct 2011 17:32:56 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 13 Oct 2011 17:32:35 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9DHWRCI006458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Oct 2011 13:32:27 -0400 Received: from anchor.twiddle.net (vpn-237-80.phx2.redhat.com [10.3.237.80]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9DHWQDl006785; Thu, 13 Oct 2011 13:32:27 -0400 Message-ID: <4E9720AA.20306@redhat.com> Date: Thu, 13 Oct 2011 18:14:00 -0000 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Sameera Deshpande CC: "gcc-patches@gcc.gnu.org" , "nickc@redhat.com" , Richard Earnshaw , "paul@codesourcery.com" , Ramana Radhakrishnan Subject: Re: [RFA/ARM][Patch 02/05]: LDRD generation instead of POP in A15 Thumb2 epilogue. References: <1318324138.2186.40.camel@e102549-lin.cambridge.arm.com> <1318324917.2186.52.camel@e102549-lin.cambridge.arm.com> In-Reply-To: <1318324917.2186.52.camel@e102549-lin.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01174.txt.bz2 On 10/11/2011 02:21 AM, Sameera Deshpande wrote: > + /* When saved-register index (i) is odd, RTXs for both the registers > + to be loaded are generated in above given LDRD pattern, and the > + pattern can be emitted now. */ > + par = emit_insn (par); > + add_reg_note (par, REG_FRAME_RELATED_EXPR, dwarf); I don't believe REG_FRAME_RELATED_EXPR does the right thing for anything besides prologues. You need to emit REG_CFA_RESTORE for the pop inside an epilogue. r~