From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12627 invoked by alias); 14 Oct 2011 21:15:34 -0000 Received: (qmail 12617 invoked by uid 22791); 14 Oct 2011 21:15:33 -0000 X-SWARE-Spam-Status: No, hits=-6.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Oct 2011 21:15:02 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9ELEaDr003145 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Oct 2011 17:14:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9ELEZPA009267; Fri, 14 Oct 2011 17:14:35 -0400 Received: from [0.0.0.0] (ovpn-113-44.phx2.redhat.com [10.3.113.44]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9ELEV4k004676; Fri, 14 Oct 2011 17:14:31 -0400 Message-ID: <4E98A636.9090401@redhat.com> Date: Fri, 14 Oct 2011 22:21:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20111001 Thunderbird/7.0.1 MIME-Version: 1.0 To: Dodji Seketeli CC: gcc-patches@gcc.gnu.org, tromey@redhat.com, gdr@integrable-solutions.net, joseph@codesourcery.com, burnus@net-b.de, charlet@act-europe.fr, bonzini@gnu.org Subject: Re: [PATCH 3/7] Emit macro expansion related diagnostics References: <8k4ni7n3xflkq6vvecxmsyox.1317761036165@email.android.com> <4E945712.6050004@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01351.txt.bz2 On 10/13/2011 01:12 PM, Dodji Seketeli wrote: > + while (true) > + { > + if (!linemap_macro_expansion_map_p (map0) > + || !linemap_macro_expansion_map_p (map1) > + || map0 == map1) > + break; I'd put the test in the condition, but if you find it clearer this way, I guess that's fine. Let's go ahead and check all this in. Jason