From: Paolo Carlini <paolo.carlini@oracle.com>
To: Gabriel Dos Reis <gdr@integrable-solutions.net>
Cc: Jason Merrill <jason@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] PR 48630 (PR 31423)
Date: Thu, 20 Oct 2011 01:06:00 -0000 [thread overview]
Message-ID: <4E9F66CC.3050604@oracle.com> (raw)
In-Reply-To: <CAAiZkiBUcTQhvqm+zryCBNchdmrfn+MdQN5QawHXQoj8BN_0Ug@mail.gmail.com>
On 10/20/2011 02:00 AM, Gabriel Dos Reis wrote:
> I believe the effect of your new patch is that if will
> always emit the suggest "did you forget "()"?" for member functions,
> even in the case where the current suggestion is correct.
> Using the type context would prevent that regression.
If you could give some guidance about the way to implement this, I may
try over the next few days, otherwise probably I will have to give up
for now (I assigned myself other PRs already), but it would be a pity,
this PR has been reported 2 times by different people, apparently it's
quite misleading. Anyway, I'm not assigned to the bug, even if I will
not be able to actually help, it would be nice if you could attach to
the audit trail a couple of nasty examples beyond what already
considered in the analyses therein (both PRs)
Thanks!
Paolo.
next prev parent reply other threads:[~2011-10-20 0:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 22:13 Paolo Carlini
2011-10-19 22:18 ` Gabriel Dos Reis
2011-10-19 23:39 ` Jason Merrill
2011-10-20 0:12 ` Paolo Carlini
2011-10-20 0:47 ` Gabriel Dos Reis
2011-10-20 1:06 ` Paolo Carlini [this message]
2011-10-20 4:40 ` Gabriel Dos Reis
2011-10-20 5:48 ` Gabriel Dos Reis
2011-10-20 6:03 ` Paolo Carlini
2011-10-21 18:31 ` Paolo Carlini
2011-10-21 18:42 ` Jason Merrill
2011-10-22 5:54 ` Gabriel Dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9F66CC.3050604@oracle.com \
--to=paolo.carlini@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).